New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change labels personalMessages and People #469

Merged

aulamber merged 3 commits into develop_tchap from 448-change-labels-people-and-personal-messages

Mar 17, 2023

Contributor

aulamber commented Mar 16, 2023 •

edited

Loading

Cf. issue #448

There are 2 purposes to this PR :

change label "Messages directs" to "Personnes" when searching a person. Cf. screenshots:

Clean our code. Up until now, we translated the string "Personal Message" of the Element code into our own "People". However it was confusing, because there was also a "People" string in Element.
So this PR adds a patch to correct the labels used so that keys and values are similar.


          Change labels personalMessages and People

f697720

aulamber requested a review from odelcroi

March 16, 2023 17:46

aulamber added 2 commits

March 16, 2023 18:54


          Remove SpotlightDialog file from patches.json

f3fcb31


          Change missing Message Direct label

f04ecf1

odelcroi approved these changes

View reviewed changes

aulamber merged commit 895a29f into develop_tchap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet