-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2-AMENDMENT_DEGREEOFESTABLISHMENT_STANDARDIZED #276
Comments
Should be made CORE - see comments under #268 |
Removed Notes on Supplementary. |
See my comment #285 (comment) under #285. I agree that this test should be CORE, but should include a note that it is expected that most results would return a INTERNAL_PREREQUISITES_NOT_MET result. |
That's conflating CORE, the UseCase, research analysis of what
organisms occurr where when, with the set of tests that we are
providing as part of the standard (mature, but not supplementary).
…
|
This (along with Pathway) has a major Use Case as set out in Groom et al. and is increasing being used in the Invasive Species community. Invasive Species are a big issue around the world and are one of the Key Issues in the Biodiversity Convention. So definitely "Widely applicable" These terms have not long been included in Darwin Core, but now that they are there is a large coordinated user community beginning to use them. This community is not specific as under the Convention on Biological Diversity, most countries and governments around the world are required to work on this issue. I would strongly push for CORE as I see no reason to exclude them as the test is well written and there are suitable Vocabularies and API. @chicoreus - I have no idea what "mature" is - this should be CORE - there is a defined Use Case. |
Source authority should be: bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/]} |
I agree @chicoreus - changing Source Authority from bdq:sourceAuthority default = "Darwin Core degreeOfEstablishment" {[https://dwc.tdwg.org/list/#dwc_degreeOfEstablishment]} {dwc:degreeOfEstablishment vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]} to bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/]} |
Should the Source Authority (API) be "https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts"? |
I think https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts is OK as a source authority because it actually has an API, as long as it is understood that the actually vocabulary is maintained at https://dwc.tdwg.org/doe/ and the GBIF API is expected to remain up to date with that. |
Fixed syntax on INTERNAL_PREREQUISITES_NOT_NET in Expected Response. |
Changed Source Authority from bdq:sourceAuthority default = "Darwin Core degreeOfEstablishment" {[https://dwc.tdwg.org/list/#dwc_degreeOfEstablishment]} {dwc:degreeOfEstablishment vocabulary API [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]} to bdq:sourceAuthority default = "GBIF DegreeOfEstablishment Vocabulary" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment]} {"dwc:degreeOfEstablishment vocabulary API" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]} |
Source Authority should be bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]} |
Changed Source Authority from bdq:sourceAuthority default = "GBIF DegreeOfEstablishment Vocabulary" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment]} {"dwc:degreeOfEstablishment vocabulary API" [https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts]} to bdq:sourceAuthority default = "Degree of Establishment Controlled Vocabulary List of Terms" {[https://dwc.tdwg.org/doe/]} {GBIF vocabulary API [https://api.gbif.org/v1/vocabularies/Pathway/concepts]} |
Oops, my mistake. Should be https://api.gbif.org/v1/vocabularies/DegreeOfEstablishment/concepts |
Corrected. |
See #275 (comment) The GBIF API is only of partial help here, it does not provide the actual Controlled Values from the TDWG vocabulary, the values it has differ in case, implementations can use the GBIF API for its additional values, but need to align the case to match the actual Controlled Value from the TDWG vocabulary for the dwc: term values (GBIF API is sufficient for the dwciri term values). |
GBIF vocabulary has now been aligned with Darwin Core. Thanks @timrobertson100 |
…, added to unit tests. Added implementations for core tests tdwg/bdq#284 tdwg/bdq#275 and tdwg/bdq#276 along with default methods and unit tests.
…#276 and tdwg/bdq#278 to recognized variants of controlled vocabulary terms.
The text was updated successfully, but these errors were encountered: