Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_SEX_STANDARD #283

Open
ArthurChapman opened this issue Feb 9, 2024 · 11 comments
Open

TG2-VALIDATION_SEX_STANDARD #283

ArthurChapman opened this issue Feb 9, 2024 · 11 comments
Labels
CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY

Comments

@ArthurChapman
Copy link
Collaborator

ArthurChapman commented Feb 9, 2024

TestField Value
GUID 88d8598b-3318-483d-9475-a5acf9887404
Label VALIDATION_SEX_STANDARD
Description Does the value of dwc:sex occur in bdq:sourceAuthority?
TestType Validation
Darwin Core Class dwc:Occurrence
Information Elements ActedUpon dwc:sex
Information Elements Consulted
Expected Response EXTERNAL_PREREQUISITES_NOT_MET if the bdq:sourceAuthority is not available; INTERNAL_PREREQUISITES_NOT_MET if dwc:sex is bdq:Empty; COMPLIANT if the value of dwc:sex is in the bdq:sourceAuthority; otherwise NOT_COMPLIANT.
Data Quality Dimension Conformance
Term-Actions SEX_STANDARD
Parameter(s) bdq:sourceAuthority
Source Authority bdq:sourceAuthority default = "GBIF Sex Vocabulary" [https://api.gbif.org/v1/vocabularies/Sex]} {"dwc:sex vocabulary API" [https://api.gbif.org/v1/vocabularies/Sex/concepts]}
Specification Last Updated 2024-02-09
Examples [dwc:sex="Male": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:sex found in the bdq:sourceAuthority"]
[dwc:sex="f": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:sex not found in the bdq:sourceAuthority"]
Source VertNet
References
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes This test must return NOT_COMPLIANT if there is leading or trailing whitespace or there are leading or trailing non-printing characters. For reference, a list of synonyms for dwc:sex values can be found at https://registry.gbif.org/vocabulary/Sex/concepts.
@ArthurChapman ArthurChapman added TG2 Validation OTHER Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT VOCABULARY Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. Parameterized Test requires a parameter labels Feb 9, 2024
@ymgan
Copy link
Collaborator

ymgan commented Feb 12, 2024

I saw in #285

References: GBIF (2021). Darwin Core Nomenclatural Type Status Vocabulary http://rs.gbif.org/vocabulary/gbif/type_status

so should this also be in the References? https://rs.gbif.org/vocabulary/gbif/sex.xml

@chicoreus
Copy link
Collaborator

Noting that the current GBIF sex vocabulary is animal centric.

@ArthurChapman
Copy link
Collaborator Author

Thanks @ymgan Reference added

@ArthurChapman ArthurChapman added Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca and removed Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Feb 22, 2024
@ArthurChapman
Copy link
Collaborator Author

Changed to Immature/Incomplete pending new Vocabulary being developed by GBIF - see comment at #284 (comment).

@ManonGros
Copy link

Just as a side note because it may be helpful for testing things, GBIF has an API for accessing vocabularies. See: https://techdocs.gbif.org/en/openapi/v1/vocabulary
When the sex vocabulary is finalised, it will be accessible programmatically via the API.

@chicoreus
Copy link
Collaborator

@ManonGros That's very helpful.

@ymgan
Copy link
Collaborator

ymgan commented Mar 20, 2024

Similar to what @Tasilee mentioned in #277, #276, seems like GBIF API for Sex vocab is live
https://api.gbif.org/v1/vocabularies/Sex/concepts

@Tasilee
Copy link
Collaborator

Tasilee commented Mar 20, 2024

Thanks @ymgan - I have edited the Source Authority accordingly. Ditto #284. Does this imply this test could be CORE or more likely Supplementary?

@ArthurChapman ArthurChapman added CORE TG2 CORE tests and removed Immature/Incomplete A test where substantial work is needed to develop the specification to the point where the test ca labels Mar 25, 2024
@ArthurChapman
Copy link
Collaborator Author

Changed to CORE following updating of GBIF Vocabulary, making a vocabulary available. This was the only reason it was made Immature/Incomplete earlier.

@ArthurChapman
Copy link
Collaborator Author

Note changed as no longer applicable now it is CORE.

@Tasilee
Copy link
Collaborator

Tasilee commented Apr 16, 2024

Changed Source Authority from

bdq:sourceAuthority default = "Darwin Core sex" {[https://dwc.tdwg.org/list/#dwc_sex]} {dwc:sex vocabulary API [https://api.gbif.org/v1/vocabularies/Sex/concepts]}

to

bdq:sourceAuthority default = "GBIF Sex Vocabulary" [https://api.gbif.org/v1/vocabularies/Sex]} {"dwc:sex vocabulary API" [https://api.gbif.org/v1/vocabularies/Sex/concepts]}

chicoreus added a commit to FilteredPush/rec_occur_qc that referenced this issue Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE TG2 CORE tests OTHER Parameterized Test requires a parameter Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation VOCABULARY
Projects
None yet
Development

No branches or pull requests

5 participants