Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for Custom Pages and Patches Functionality #180

Closed
dmaahs2017 opened this issue Apr 22, 2021 · 6 comments
Closed

Create tests for Custom Pages and Patches Functionality #180

dmaahs2017 opened this issue Apr 22, 2021 · 6 comments
Assignees
Labels

Comments

@dmaahs2017
Copy link
Contributor

dmaahs2017 commented Apr 22, 2021

Create Integration and Unit Tests for functiality added in PR #142.

closes #180

@dbrgn
Copy link
Collaborator

dbrgn commented Apr 22, 2021

@dmaahs2017 from your comment in #142 it seems you're willing to implement these tests, right? I assigned the issue to you, otherwise just let me know 🙂

@dmaahs2017
Copy link
Contributor Author

@dmaahs2017 from your comment in #142 it seems you're willing to implement these tests, right? I assigned the issue to you, otherwise just let me know 🙂

Yep, thanks!

@dmaahs2017
Copy link
Contributor Author

@niklasmohrin @dbrgn can we close this issue? or is there a way to mark it as complete as opposed to just closing it?

@dbrgn
Copy link
Collaborator

dbrgn commented May 2, 2021

No, closing is fine!

@dbrgn dbrgn closed this as completed May 2, 2021
@niklasmohrin
Copy link
Collaborator

@dmaahs2017 A note on that: When your initial PR comment has something like "fixes #xxx", the issue will be closed automatically when the PR is merged

https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

@dmaahs2017
Copy link
Contributor Author

A note on that: When your initial PR comment has something like "fixes #xxx", the issue will be closed automatically when the PR is merged

Oh that's cool, Today I learned 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants