Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for PR #142 #183

Merged
merged 4 commits into from
Apr 23, 2021
Merged

Tests for PR #142 #183

merged 4 commits into from
Apr 23, 2021

Conversation

dmaahs2017
Copy link
Contributor

@dmaahs2017 dmaahs2017 commented Apr 22, 2021 •
edited
Loading

PR for Issue: #180

Adds tests that should have been added in PR #182

Added

  • 3 integration tests for custom pages, including a 2 new markdown files for testing
  • renamed my poorly named variable when I came across it again
  • Unit tests for PageLookupResult
  • Some new helper functions for the TestEnv struct for integration tests

@dmaahs2017 dmaahs2017 changed the title Tests for PR #141 Tests for PR #142 Apr 22, 2021
@dmaahs2017
Copy link
Contributor Author

dmaahs2017 commented Apr 22, 2021 •
edited
Loading

@dbrgn or @niklasmohrin Tests are ready for review :)

threema-danilo
threema-danilo reviewed Apr 22, 2021
View reviewed changes
Copy link

@threema-danilo threema-danilo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(...Edit: I should separate work- and after-work-browsers more clearly... The side effects of home office.)

dbrgn
dbrgn reviewed Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@dbrgn dbrgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

Can you run rustfmt, so that CI passes?

niklasmohrin
niklasmohrin reviewed Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I only have a small detail 👍

src/cache.rs Outdated Show resolved Hide resolved
@dbrgn dbrgn merged commit 0fce79f into tealdeer-rs:master Apr 23, 2021
@dmaahs2017 dmaahs2017 mentioned this pull request May 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threema-danilo threema-danilo threema-danilo left review comments

@dbrgn dbrgn Awaiting requested review from dbrgn

@niklasmohrin niklasmohrin Awaiting requested review from niklasmohrin

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmaahs2017 @dbrgn @niklasmohrin @threema-danilo