Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

DatePickerInput: fixed clearing logic #2464

Merged
merged 6 commits into from
Nov 23, 2022
Merged

DatePickerInput: fixed clearing logic #2464

merged 6 commits into from
Nov 23, 2022

Conversation

qubis741
Copy link
Contributor

@qubis741 qubis741 commented Nov 23, 2022 •
edited by KristofColpaert
Loading

Description

  • pass empty string to onChange if input is empty
  • improve clearing and displaying logic of clear indicator

Manual Check

  • on clearing of input value by removing text (not clicking on clear), clear indicator disappears
  • on clearing of input value by removing text (not clicking on clear), empty string is passed to onChange

@qubis741 qubis741 changed the title DatePickerInput: improved clearing logic DatePickerInput: fixed clearing logic Nov 23, 2022
@qubis741 qubis741 self-assigned this Nov 23, 2022
@qubis741 qubis741 added the ready label Nov 23, 2022
@qubis741
Copy link
Contributor Author

On hold until #2465 (review)

@KristofColpaert
Copy link
Contributor

MC ok 👌

JorenSaeyTL
JorenSaeyTL previously approved these changes Nov 23, 2022
View reviewed changes
@qubis741 qubis741 merged commit b54ede7 into next-release Nov 23, 2022
@qubis741 qubis741 deleted the FRAF-1154-v6 branch November 23, 2022 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lorgan3 lorgan3 lorgan3 approved these changes

@eniskraasniqi1 eniskraasniqi1 eniskraasniqi1 approved these changes

@BeirlaenAaron BeirlaenAaron Awaiting requested review from BeirlaenAaron

@driesd driesd Awaiting requested review from driesd

@farazatarodi farazatarodi Awaiting requested review from farazatarodi farazatarodi is a code owner

@jelledc jelledc Awaiting requested review from jelledc

@lowiebenoot lowiebenoot Awaiting requested review from lowiebenoot lowiebenoot is a code owner

@stefaandevylder stefaandevylder Awaiting requested review from stefaandevylder

@KristofColpaert KristofColpaert Awaiting requested review from KristofColpaert

@JorenSaeyTL JorenSaeyTL Awaiting requested review from JorenSaeyTL

Assignees

@qubis741 qubis741

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qubis741 @KristofColpaert @lorgan3 @eniskraasniqi1 @JorenSaeyTL