This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofColpaert
requested review from
lowiebenoot,
jelledc,
lorgan3,
driesd,
qubis741,
stefaandevylder,
eniskraasniqi1,
BeirlaenAaron,
JorenSaeyTL and
farazatarodi
November 23, 2022 13:25
Q: why is the title optional? |
qubis741
previously approved these changes
Nov 23, 2022
2 tasks
stefaandevylder
previously approved these changes
Nov 23, 2022
Messages are used without a |
driesd
previously approved these changes
Nov 23, 2022
KristofColpaert
dismissed stale reviews from driesd, stefaandevylder, and qubis741
via
November 23, 2022 14:03
daaa6c0
qubis741
previously approved these changes
Nov 23, 2022
JorenSaeyTL
previously approved these changes
Nov 23, 2022
KristofColpaert
dismissed stale reviews from JorenSaeyTL and qubis741
via
November 23, 2022 14:07
de10c4b
KristofColpaert
requested review from
driesd,
stefaandevylder,
JorenSaeyTL and
qubis741
November 23, 2022 14:07
qubis741
approved these changes
Nov 23, 2022
Manually checked ✅ |
JorenSaeyTL
approved these changes
Nov 23, 2022
driesd
approved these changes
Nov 23, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MessageProps
extendBoxProps
title
property optional (null/undefined check already in place)Manual check
Message
stories still work