Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Make MessageProps extend BoxProps #2465

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Make MessageProps extend BoxProps #2465

merged 5 commits into from
Nov 23, 2022

Conversation

KristofColpaert
Copy link
Contributor

Description

  • Make MessageProps extend BoxProps
  • Make the title property optional (null/undefined check already in place)

Manual check

  • Assert that Message stories still work

@KristofColpaert KristofColpaert self-assigned this Nov 23, 2022
@farazatarodi
Copy link
Collaborator

Q: why is the title optional?

@KristofColpaert KristofColpaert marked this pull request as ready for review November 23, 2022 13:28
qubis741
qubis741 previously approved these changes Nov 23, 2022
View reviewed changes
@qubis741 qubis741 mentioned this pull request Nov 23, 2022
Merged
2 tasks
@KristofColpaert
Copy link
Contributor Author

Q: why is the title optional?

Messages are used without a title too. It was already optional in code, the code to check for undefined or null was already there, but the property itself was still mandatory.

driesd
driesd previously approved these changes Nov 23, 2022
View reviewed changes
qubis741
qubis741 previously approved these changes Nov 23, 2022
View reviewed changes
JorenSaeyTL
JorenSaeyTL previously approved these changes Nov 23, 2022
View reviewed changes
@qubis741
Copy link
Contributor

Manually checked ✅

@qubis741 qubis741 merged commit 10a2587 into next-release Nov 23, 2022
@qubis741 qubis741 deleted the fix/message-boxprops branch November 23, 2022 14:30
@lorgan3 lorgan3 mentioned this pull request Nov 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@driesd driesd driesd approved these changes

@qubis741 qubis741 qubis741 approved these changes

@JorenSaeyTL JorenSaeyTL JorenSaeyTL approved these changes

@lowiebenoot lowiebenoot Awaiting requested review from lowiebenoot lowiebenoot is a code owner

@jelledc jelledc Awaiting requested review from jelledc

@lorgan3 lorgan3 Awaiting requested review from lorgan3

@eniskraasniqi1 eniskraasniqi1 Awaiting requested review from eniskraasniqi1

@BeirlaenAaron BeirlaenAaron Awaiting requested review from BeirlaenAaron

@farazatarodi farazatarodi Awaiting requested review from farazatarodi farazatarodi is a code owner

@stefaandevylder stefaandevylder Awaiting requested review from stefaandevylder

Assignees

@KristofColpaert KristofColpaert

Labels
enhancement ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KristofColpaert @farazatarodi @qubis741 @driesd @stefaandevylder @JorenSaeyTL