Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring test coverage up to 100% #10

Closed
zupo opened this issue Jul 25, 2018 · 5 comments
Closed

Bring test coverage up to 100% #10

zupo opened this issue Jul 25, 2018 · 5 comments
Assignees
@ikolar

Comments

@zupo
Copy link
Member

zupo commented Jul 25, 2018 •
edited
Loading

We're currently at 97%. We should be at 100%.

When done, Travis should fail if coverage slips under 100%.
ikolar added a commit that referenced this issue Jan 7, 2019
@ikolar
Raised code coverage for pyramid_heroku/herokuapp_access.py to 100%.
15c0675 
Had some issues getting the logging test to work.  In the end, I had to make
the structlog version log to the standard log, so that zope could still
catch it's messages.

Ref: #10
@ikolar
Copy link
Contributor

ikolar commented Jan 7, 2019

Up to 99% now. Two more files to do.

ikolar added a commit that referenced this issue Jan 7, 2019
@ikolar
Covered one of the remaining two uncovered lises (if set._formation were
9ca15b9 
defined before the first call).

One line left.

Ref: #10
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Test coverage is now 100%.
f653e23 
Ref: #10
@ikolar
Copy link
Contributor

ikolar commented Jan 8, 2019

Coverage report now says 100%:

$ pipenv run coverage report
Name                                            Stmts   Miss Branch BrPart  Cover
---------------------------------------------------------------------------------
pyramid_heroku/__init__.py                         15      0      6      0   100%
pyramid_heroku/client_addr.py                       8      0      2      0   100%
pyramid_heroku/herokuapp_access.py                 22      0      6      0   100%
pyramid_heroku/migrate.py                          79      0     18      0   100%
pyramid_heroku/tests/__init__.py                    0      0      0      0   100%
pyramid_heroku/tests/test_client_addr.py           32      0      0      0   100%
pyramid_heroku/tests/test_herokuapp_access.py      64      0      0      0   100%
pyramid_heroku/tests/test_migrate.py              111      0      0      0   100%
pyramid_heroku/tests/test_utils.py                 33      0      0      0   100%
---------------------------------------------------------------------------------
TOTAL                                             364      0     32      0   100%

ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Added missing newline at the end of .travis.yml
0209102 
Ref: #10
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
When done, Travis should fail if coverage slips under 100%.
15e6c2e 
Ref: #10
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Removed Pipfile additions not necessary for this issue (they belong to …
703e13f 
…#13).

Ref: #10
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Removed the call to black from .travis.yml (since it belongs to issue #…
baef42f 
…13).

Ref: #10
ikolar added a commit that referenced this issue Jan 8, 2019
@ikolar
Forgot the lock.
f572b28 
Ref: #10
@ikolar ikolar mentioned this issue Jan 8, 2019
Merged
@ikolar
Copy link
Contributor

ikolar commented Jan 8, 2019

@zupo mind taking a look at the new tests? Ty

@zupo
Copy link
Member Author

zupo commented Jan 8, 2019

Already approved.

@ikolar
Copy link
Contributor

ikolar commented Jan 9, 2019

Merged, closing.

@ikolar ikolar closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikolar ikolar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikolar @zupo