Fix/test coverage #17

ikolar · 2019-01-08T14:07:11Z

Test coverage should not be at 100%:

in coveragerc, the if name = "main" was adjusted to allow for both single and double quotes,
in .travis.yml, travis will now fail if coverage falls bellow 100%
in Pipfile, struclog is now imported because it is needed in test_heroku_access.py
in test_heroku_access.py, the test for the call() method now also tests the version that uses structlog instead of the standard logging library.
in test_migrate.py, tests for two conditional lines were added
in test_utils.py, the two tests that might raise an Error are now separated.

Hope that's all.

Ref: #10

Also added a call to it in .travis.yml. Not sure whether this is the correct place, and this .travis.yml is quite different than the one in woocart-api. Help appreciated. Ref: #13

Had some issues getting the logging test to work. In the end, I had to make the structlog version log to the standard log, so that zope could still catch it's messages. Ref: #10

defined before the first call). One line left. Ref: #10

Ref: #10

…#13). Ref: #10

…13). Ref: #10

Ref: #10

zupo

👍

ikolar added 9 commits January 7, 2019 12:40

Added black to the [dev-packages] section in Pipfile.

134982c

Also added a call to it in .travis.yml. Not sure whether this is the correct place, and this .travis.yml is quite different than the one in woocart-api. Help appreciated. Ref: #13

Raised code coverage for pyramid_heroku/herokuapp_access.py to 100%.

15c0675

Had some issues getting the logging test to work. In the end, I had to make the structlog version log to the standard log, so that zope could still catch it's messages. Ref: #10

Covered one of the remaining two uncovered lises (if set._formation were

9ca15b9

defined before the first call). One line left. Ref: #10

Test coverage is now 100%.

f653e23

Ref: #10

Added missing newline at the end of .travis.yml

0209102

Ref: #10

When done, Travis should fail if coverage slips under 100%.

15e6c2e

Ref: #10

Removed Pipfile additions not necessary for this issue (they belong to …

703e13f

…#13). Ref: #10

Removed the call to black from .travis.yml (since it belongs to issue #…

baef42f

…13). Ref: #10

Forgot the lock.

f572b28

Ref: #10

zupo approved these changes Jan 8, 2019

View reviewed changes

ikolar merged commit 53c58b9 into master Jan 9, 2019

ikolar deleted the fix/test_coverage branch January 9, 2019 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/test coverage #17

Fix/test coverage #17

ikolar commented Jan 8, 2019 •

edited

Loading

zupo left a comment

Fix/test coverage #17

Fix/test coverage #17

Conversation

ikolar commented Jan 8, 2019 • edited Loading

zupo left a comment

Choose a reason for hiding this comment

ikolar commented Jan 8, 2019 •

edited

Loading