Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testcloud domain API v2 #2078

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

frantisekz
Copy link
Collaborator

@frantisekz frantisekz commented May 12, 2023

Refactors domain configuration interface between tmt and testcloud, to allow greater flexibility and superior api stability when making changes and additions in the future.

Apart from that, doesn't expose support for (will come as a separate PR):

testcloud counterparts:

(compatible testcloud built at): https://copr.fedorainfracloud.org/coprs/frantisekz/testcloud-wip/

@frantisekz frantisekz added the plugin | testcloud The testcloud virtual provision plugin label May 12, 2023
@frantisekz frantisekz changed the title Testcloud instance api v2 Testcloud domain api v2 May 12, 2023
@frantisekz frantisekz force-pushed the testcloud_instance_api_v2 branch 2 times, most recently from 66fd9dd to 2ebd5ba Compare May 16, 2023 14:55
@frantisekz frantisekz force-pushed the testcloud_instance_api_v2 branch 8 times, most recently from aef9afe to 2b9d8ad Compare June 5, 2023 16:20
@frantisekz frantisekz marked this pull request as ready for review June 5, 2023 16:40
@frantisekz frantisekz force-pushed the testcloud_instance_api_v2 branch 4 times, most recently from 2ac1325 to 24c0427 Compare June 6, 2023 05:26
@lukaszachy
Copy link
Collaborator

@kkaarreell FYI - This adds TPM flag for provision -h virtual

@lukaszachy lukaszachy added the step | provision Stuff related to the provision step label Jun 6, 2023
@kkaarreell
Copy link
Collaborator

Hi @frantisekz , I would like to test this code but may I ask you to rebase first? For proper testing using my test I need the multi-host related code so it would help me a lot if this would be up to date. Thank you.

@frantisekz
Copy link
Collaborator Author

Hi @frantisekz , I would like to test this code but may I ask you to rebase first? For proper testing using my test I need the multi-host related code so it would help me a lot if this would be up to date. Thank you.

Sure, done!

thrix
thrix previously requested changes Jun 19, 2023
tmt/steps/provision/testcloud.py Outdated Show resolved Hide resolved
tmt/steps/provision/testcloud.py Outdated Show resolved Hide resolved
@frantisekz frantisekz force-pushed the testcloud_instance_api_v2 branch 2 times, most recently from d4ada47 to 7a1958c Compare June 19, 2023 13:08
@frantisekz
Copy link
Collaborator Author

Looks good and works nicely! Thanks! Added just one minor suggestion. Plus, I guess, we should also bump the testcloud require to make sure the new api is installed on the user system, right?

Updated, feedback addressed, thanks!

@psss
Copy link
Collaborator

psss commented Sep 5, 2023

Updated, feedback addressed, thanks!

Nice, thanks!

Hint: During the pull request review it's better to add new commits rather then amending existing ones. It makes it easier to see what actually changed, especially when the force-push is combined with a rebase.

@frantisekz
Copy link
Collaborator Author

Hint: During the pull request review it's better to add new commits rather then amending existing ones. It makes it easier to see what actually changed, especially when the force-push is combined with a rebase.

Yeah, sorry for that, I probably took it as too trivial no do it the proper way around, will pay attention to it the next time.

@psss
Copy link
Collaborator

psss commented Sep 5, 2023

Yeah, sorry for that, I probably took it as too trivial no do it the proper way around, will pay attention to it the next time.

Sure, no problemo.

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now, we just need to wait until testcloud gets to stable repos.

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'tmt': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'fedora-all': None, 'epel-9': None, 'fedora-39': {'additional_repos': 'https://download.copr.fedorainfracloud.org/results/frantisekz/testcloud-wip/fedora-39-x86_64/'}} (type <class 'dict'>)."]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

@packit-as-a-service
Copy link

Failed to load packit config file:

Cannot parse package config: ValidationError({'jobs': {0: {'packages': defaultdict(<class 'dict'>, {'tmt': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'fedora-all': None, 'epel-9': None, 'fedora-39': {'additional_repos': ['https://download.copr.fedorainfracloud.org/results/frantisekz/testcloud-wip/fedora-39-x86_64/']}} (type <class 'dict'>)."]}}})}}}).

For more info, please check out the documentation or contact the Packit team.

@psss
Copy link
Collaborator

psss commented Sep 6, 2023

/packit test

@psss
Copy link
Collaborator

psss commented Sep 6, 2023

/packit build

@psss psss self-assigned this Sep 6, 2023
@psss psss changed the title Use testcloud domain api v2 Use testcloud domain API v2 Sep 6, 2023
@psss psss dismissed thrix’s stale review September 6, 2023 10:33

Newly added options have been moved to a separate pull request.

@psss psss merged commit acc601b into teemtee:main Sep 6, 2023
14 of 15 checks passed
happz added a commit that referenced this pull request Jan 7, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 5, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 8, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 12, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 19, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 20, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 21, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 22, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Feb 29, 2024
Based on code introduced in #2078,
but honoring HW requirements.
happz added a commit that referenced this pull request Mar 5, 2024
Based on code introduced in #2078,
but honoring HW requirements.
psss pushed a commit that referenced this pull request Mar 7, 2024
Based on code introduced in #2078,
but honoring HW requirements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin | testcloud The testcloud virtual provision plugin step | provision Stuff related to the provision step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants