-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use testcloud
domain API v2
#2078
Conversation
66fd9dd
to
2ebd5ba
Compare
aef9afe
to
2b9d8ad
Compare
2ac1325
to
24c0427
Compare
@kkaarreell FYI - This adds TPM flag for |
Hi @frantisekz , I would like to test this code but may I ask you to rebase first? For proper testing using my test I need the multi-host related code so it would help me a lot if this would be up to date. Thank you. |
24c0427
to
26c3f3a
Compare
Sure, done! |
d4ada47
to
7a1958c
Compare
Updated, feedback addressed, thanks! |
Nice, thanks! Hint: During the pull request review it's better to add new commits rather then amending existing ones. It makes it easier to see what actually changed, especially when the force-push is combined with a rebase. |
Yeah, sorry for that, I probably took it as too trivial no do it the proper way around, will pay attention to it the next time. |
Sure, no problemo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good now, we just need to wait until testcloud
gets to stable repos.
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
569f821
to
a303984
Compare
Failed to load packit config file:
For more info, please check out the documentation or contact the Packit team. |
a303984
to
05b2a9d
Compare
/packit test |
/packit build |
05b2a9d
to
acc601b
Compare
Newly added options have been moved to a separate pull request.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Based on code introduced in #2078, but honoring HW requirements.
Refactors domain configuration interface between tmt and testcloud, to allow greater flexibility and superior api stability when making changes and additions in the future.
Apart from that, doesn't expose support for (will come as a separate PR):
testcloud counterparts:
(compatible testcloud built at): https://copr.fedorainfracloud.org/coprs/frantisekz/testcloud-wip/