Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for emulated TPM into virtual provision plugin #2596

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add support for emulated TPM into virtual provision plugin #2596

merged 1 commit into from
Mar 7, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jan 7, 2024 •
edited
Loading

Based on code introduced in #2078, but honoring HW requirements.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • mention the version
  • include a release note

@happz happz added plugin | testcloud The testcloud virtual provision plugin area | hardware Implementation of hardware requirements labels Jan 7, 2024
@happz
Copy link
Collaborator Author

happz commented Jan 7, 2024

@frantisekz FYI, getting back to what you started in #2078. TPM seems to be easy enough - I'll also include a test, I have no idea whether this works or not, yet.

@frantisekz
Copy link
Collaborator

@happz Thanks for tag here. It should work if there aren't any new issues in libvirt (the implementation of tpm is really very thin around the libvirt itself).

On the other hand, if you don't hurry with this, I can very easily add support for tpm 1.0 too, so you don't have to care about which version is requested tmt side.

@happz happz force-pushed the hardware-constraints-for-value-types branch from ca58d93 to aef8e77 Compare January 11, 2024 12:31
@frantisekz
Copy link
Collaborator

tpm 1.2 is now supported too : https://pagure.io/testcloud/c/89f1c024ca829543de7f74f89329158c6dee3d83?branch=master

You can pass version str to the TPMConfiguration() object, libvirt supports 1.2 or 2.0 (default).

Ping me please when you'd need a new testcloud release with this.

@psss psss force-pushed the hardware-constraints-for-value-types branch from aef8e77 to adaeda0 Compare January 12, 2024 14:49
Base automatically changed from hardware-constraints-for-value-types to main January 12, 2024 15:24
@happz happz added this to the 1.32 milestone Jan 22, 2024
@happz happz force-pushed the testcloud-tpm-hw-constraint branch from eaad8e4 to 461fd23 Compare February 5, 2024 18:54
@happz happz marked this pull request as ready for review February 5, 2024 18:55
@happz happz force-pushed the testcloud-tpm-hw-constraint branch from 461fd23 to 35518c8 Compare February 8, 2024 11:27
@happz
Copy link
Collaborator Author

happz commented Feb 8, 2024

/packit test

@happz happz force-pushed the testcloud-tpm-hw-constraint branch from 35518c8 to ee95609 Compare February 12, 2024 12:08
@happz happz marked this pull request as draft February 19, 2024 14:27
@happz happz force-pushed the testcloud-tpm-hw-constraint branch from ee95609 to f9842b2 Compare February 19, 2024 14:28
@happz
Copy link
Collaborator Author

happz commented Feb 20, 2024

tpm 1.2 is now supported too : https://pagure.io/testcloud/c/89f1c024ca829543de7f74f89329158c6dee3d83?branch=master

You can pass version str to the TPMConfiguration() object, libvirt supports 1.2 or 2.0 (default).

Ping me please when you'd need a new testcloud release with this.

Sorry, I missed your comment.

Yes, it would be nice to have a testcloud release with this feature. I'm closing on adding a test for it in tmt, this PR should be ready for reviews Soon(TM).

@happz happz force-pushed the testcloud-tpm-hw-constraint branch from f9842b2 to eec52fe Compare February 20, 2024 11:04
@happz happz marked this pull request as ready for review February 20, 2024 11:20
@happz happz added the ci | full test Pull request is ready for the full test execution label Feb 20, 2024
@happz happz force-pushed the testcloud-tpm-hw-constraint branch from 4fb6340 to 43f22ee Compare February 21, 2024 09:26
@happz happz mentioned this pull request Feb 21, 2024
Merged
4 tasks
@frantisekz
Copy link
Collaborator

Sorry, I missed your comment.

Yes, it would be nice to have a testcloud release with this feature. I'm closing on adding a test for it in tmt, this PR should be ready for reviews Soon(TM).

Okey dokey, I'll try to sprint in to have the next release tagged by around friday, I have bunch of wip stuff near the finish line that I'd like to include in.

@happz happz force-pushed the testcloud-tpm-hw-constraint branch from 8ef36dd to 375e40e Compare February 22, 2024 12:55
@frantisekz
Copy link
Collaborator

testcloud-0.9.11 was released, TPMConfiguration objects now accept version parameter ("1.2" or "2.0" which are the only ones supported by libvirt).

@happz happz force-pushed the testcloud-tpm-hw-constraint branch from 375e40e to ee576ab Compare February 29, 2024 09:51
@happz
Copy link
Collaborator Author

happz commented Feb 29, 2024

testcloud-0.9.11 was released, TPMConfiguration objects now accept version parameter ("1.2" or "2.0" which are the only ones supported by libvirt).

Lovely, thank you! Tested both with testcloud-0.9.10 and testcloud-0.9.12, works perfectly.

@happz happz force-pushed the testcloud-tpm-hw-constraint branch from ee576ab to 9c25dd1 Compare March 5, 2024 07:34
@happz happz added the status | blocking other work An important pull request, blocking other pull requests or issues label Mar 6, 2024
@happz happz mentioned this pull request Mar 7, 2024
Merged
1 task
psss
psss approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for implementing this.

@happz @psss
Add support for emulated TPM into virtual provision plugin
14c9c26 
Based on code introduced in #2078,
but honoring HW requirements.
@psss psss force-pushed the testcloud-tpm-hw-constraint branch from 9c25dd1 to 14c9c26 Compare March 7, 2024 09:34
@psss psss self-assigned this Mar 7, 2024
@psss
Copy link
Collaborator

psss commented Mar 7, 2024

/packit test

1 similar comment
@psss
Copy link
Collaborator

psss commented Mar 7, 2024

/packit test

@psss psss merged commit 14c9c26 into main Mar 7, 2024
20 of 22 checks passed
@psss psss deleted the testcloud-tpm-hw-constraint branch March 7, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@frantisekz frantisekz Awaiting requested review from frantisekz frantisekz is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution plugin | testcloud The testcloud virtual provision plugin status | blocking other work An important pull request, blocking other pull requests or issues
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @frantisekz @psss