Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare and finish steps save results of their phases [Step results #4] #2979

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 2, 2024

Pull Request Checklist

Depends on #2978

  • implement the feature
  • extend the test coverage

@happz happz added this to the 1.35 milestone Jun 2, 2024
@happz happz force-pushed the plugins-save-results-primitives branch from a99ccb4 to 8e75089 Compare June 15, 2024 11:38
@happz happz force-pushed the plugins-prepare-finish-save-results branch 2 times, most recently from 029171f to 230ca1d Compare June 15, 2024 12:00
@happz happz changed the title Plugins prepare finish save results Prepare and finish steps save results of their phases Jun 15, 2024
@happz happz changed the title Prepare and finish steps save results of their phases Prepare and finish steps save results of their phases [Step results #4] Jun 15, 2024
@happz happz marked this pull request as ready for review June 15, 2024 12:14
@happz happz added step | prepare Stuff related to the prepare step step | finish Stuff related to the finish step area | results Related to how tmt stores and shares results labels Jun 15, 2024
@happz happz modified the milestones: 1.35, 1.36 Aug 1, 2024
@happz happz force-pushed the plugins-save-results-primitives branch from a670359 to d315345 Compare August 6, 2024 18:10
@happz happz force-pushed the plugins-prepare-finish-save-results branch from 2773d15 to d362ba0 Compare August 6, 2024 18:39
@happz happz added the ci | full test Pull request is ready for the full test execution label Aug 6, 2024
@happz
Copy link
Collaborator Author

happz commented Aug 6, 2024

/packit build

@happz happz added the status | blocked The merging of PR is blocked on some other issue label Aug 6, 2024
@happz
Copy link
Collaborator Author

happz commented Aug 6, 2024

Blocked on #3106 - after swapping phase results for subresults, we can add the actual (step) phase result class.

@happz happz force-pushed the plugins-save-results-primitives branch from d315345 to a4139c5 Compare August 11, 2024 10:26
Base automatically changed from plugins-save-results-primitives to main August 12, 2024 07:08
@happz happz force-pushed the plugins-prepare-finish-save-results branch from d362ba0 to 72a9c8f Compare August 12, 2024 07:08
@happz happz removed the status | blocked The merging of PR is blocked on some other issue label Aug 12, 2024
@happz happz force-pushed the plugins-prepare-finish-save-results branch 2 times, most recently from d3060af to d834257 Compare August 13, 2024 15:00
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 13, 2024
@happz happz force-pushed the plugins-prepare-finish-save-results branch 2 times, most recently from 470c905 to 780df71 Compare August 14, 2024 13:58
@happz happz force-pushed the plugins-prepare-finish-save-results branch from 780df71 to 4a17a03 Compare August 15, 2024 08:14
@happz
Copy link
Collaborator Author

happz commented Aug 15, 2024

Unrelated failures, merging.

@happz happz merged commit 54dfd29 into main Aug 15, 2024
19 of 20 checks passed
@happz happz deleted the plugins-prepare-finish-save-results branch August 15, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | results Related to how tmt stores and shares results ci | full test Pull request is ready for the full test execution status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | finish Stuff related to the finish step step | prepare Stuff related to the prepare step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants