Move timestamp/duration formatting to utils [Step results #5] #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
happz
changed the title
8 tasks
happz
added
the
code | no functional change
happz
force-pushed
the
plugins-move-timestamp-formatting
branch
from
029171f
to
f0c8125
Compare
martinhoyer
approved these changes
Aug 1, 2024
happz
force-pushed
the
plugins-prepare-finish-save-results
branch
from
2773d15
to
d362ba0
Compare
happz
requested review from
KwisatzHaderach,
dav-pascual and
frantisekz
as code owners
happz
force-pushed
the
plugins-move-timestamp-formatting
branch
from
f0c8125
to
6da7544
Compare
happz
force-pushed
the
plugins-prepare-finish-save-results
branch
from
d362ba0
to
72a9c8f
Compare
|
Tests are failing with: |
happz
force-pushed
the
plugins-prepare-finish-save-results
branch
from
d33cd48
to
d3060af
Compare
therazix
reviewed
Aug 13, 2024
happz
force-pushed
the
plugins-prepare-finish-save-results
branch
4 times, most recently
from
780df71
to
4a17a03
Compare
martinhoyer
approved these changes
Aug 19, 2024
happz
force-pushed
the
plugins-move-timestamp-formatting
branch
from
3b7f96e
to
1ebba5d
Compare
therazix
approved these changes
Aug 29, 2024
happz
force-pushed
the
plugins-move-timestamp-formatting
branch
from
1ebba5d
to
7e0f36e
Compare
happz
added
the
status | ready for merge
KwisatzHaderach
approved these changes
Aug 29, 2024
We will need them from other places, it's not longer just `execute` who will be dealign with times.
happz
force-pushed
the
plugins-move-timestamp-formatting
branch
from
7e0f36e
to
c545bb9
Compare
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
…eemtee#3019) We will need them from other places, it's not longer just `execute` who will be dealign with times. Co-authored-by: Martin Hoyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need them from other places, it's not longer just
executewho will be dealign with times.Depends on #2979
Pull Request Checklist