Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tasks to cover PipelineResource use cases #95

Closed
3 of 6 tasks
vdemeester opened this issue Oct 3, 2019 · 8 comments
Closed
3 of 6 tasks

Add Tasks to cover PipelineResource use cases #95

vdemeester opened this issue Oct 3, 2019 · 8 comments
Assignees
Labels
area/release Indicates an issue on release (process, tasks). kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@vdemeester
Copy link
Member

vdemeester commented Oct 3, 2019

In the recent PipelineResource working group and as presented during Oct. 2 working group, and related to tektoncd/pipeline#1369 :

In the most recent PipelineResource working group we landed on the idea of keeping PipelineResources as Alpha when the rest of the Tekton resources move to Beta. So with that approach we'll need to make sure that our docs correctly reflect the "right" way to work with external resources.

In this direction, we need to provide generic tasks that cover the use case of PipelineResource today, e.g. a GitTask, a DockerImageTask, etc... This issue is there to track work related to that.

Current PipelineResource to cover

Additionnal generic tasks

  • Other VCS, like mercurial, …

Feel free to add your ideas/need in comment, I'll update this issue's description 😉

@vdemeester vdemeester added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2019
@vdemeester vdemeester self-assigned this Oct 3, 2019
@vdemeester vdemeester added the area/release Indicates an issue on release (process, tasks). label Oct 3, 2019
@ghost
Copy link

ghost commented Feb 18, 2020

Another part of this that we'll need to think about is that currently the PipelineResources have their credentials initialized using Pipeline's creds-init image.

@bobcatfish and I were talking about this a bit last week / a few weeks ago. Maybe we could offer up creds-init as its own Task to ease migration off of PipelineResources? The only problem them would be that the user would need to provide a workspace so that the initialized creds can be written to it and then mounted at the appropriate place by the PipelineResource tasks themselves. Seems complicated to me. This is, I think, where having tasks with Pre and Post Run Steps could really help out - a creds-init PreRunStep could initialize a Task's ~/.ssh / ~/.docker directories based on attached secrets.

bobcatfish added a commit to bobcatfish/catalog that referenced this issue Mar 5, 2020
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of tektoncd#95
bobcatfish added a commit to bobcatfish/catalog that referenced this issue Mar 5, 2020
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of tektoncd#95
bobcatfish added a commit to bobcatfish/catalog that referenced this issue Mar 5, 2020
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of tektoncd#95
tekton-robot pushed a commit that referenced this issue Mar 6, 2020
With the addition of workspaces and results, we are exploring a world
without PipelineResources! (see
tektoncd/pipeline#1673)

To that end, this commit adds a Task that does the same things as the
PullRequest PipelineResource. It still uses the same underlying image,
pullrequest-init, which is currently built and published as part of the
Tekton Pipelines release, but which one day may be in another repo and
published separately.

This also includes a "sample" which uses the Task to post a comment on
an existing known PR - the only requirement to run it is a secret that
contains a github token.

Part of #95
@vdemeester vdemeester assigned ghost Mar 17, 2020
divyansh42 added a commit to divyansh42/pipeline that referenced this issue Apr 6, 2020
Kubeconfigwriter needs to improved to replace pipeline resource type "cluster" with the kubeconfig-creator task.
In order to do that, some extra configurations(e.g. client-key-data, client-certificate-data) needs to be added with
some changes in the implementation.

Ref: [tektoncd/catalog#95], [tektoncd/catalog#251]

Signed-off-by: Divyansh42 <[email protected]>
divyansh42 added a commit to divyansh42/pipeline that referenced this issue Apr 7, 2020
Kubeconfigwriter needs to be improved to replace pipeline resource type "cluster" with the kubeconfig-creator task.
In order to do that, some extra configurations(e.g. client-key-data, client-certificate-data) needs to be added in the
Resource struct with some changes in the kubeconfigwriter implementation.

Ref: [tektoncd/catalog#95], [tektoncd/catalog#251]

Signed-off-by: Divyansh42 <[email protected]>
divyansh42 added a commit to divyansh42/pipeline that referenced this issue Apr 9, 2020
Kubeconfigwriter needs to be improved to replace pipeline resource type "cluster" with the kubeconfig-creator task.
In order to do that, some extra configurations(e.g. client-key-data, client-certificate-data) needs to be added in the
Resource struct with some changes in the kubeconfigwriter implementation.

Ref: [tektoncd/catalog#95], [tektoncd/catalog#251]

Signed-off-by: Divyansh42 <[email protected]>
tekton-robot pushed a commit that referenced this issue May 4, 2020
This is a part of documenting and providing task in the catalog that would help user not using PipelineResource for accesing the target cluster.
This can help in creating a kubeconfig file by providing cluster credentials to the task.

Ref:#95

Signed-off-by: Divyansh42 <[email protected]>
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 13, 2020
@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stobias123
Copy link

@sbwsg - Any chance you could point a weary traveler to docs about this creds implementation? I'm having trouble finding how to set creds for the git-clone task in catalog.

@vinamra28
Copy link
Member

@stobias123
Copy link

stobias123 commented Jan 28, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Indicates an issue on release (process, tasks). kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants