-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement in the kubeconfigwriter #2366
Improvement in the kubeconfigwriter #2366
Conversation
Hi @divyansh42. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The following is the coverage report on pkg/.
|
cc5a7a4
to
9bdb0e5
Compare
The following is the coverage report on pkg/.
|
9bdb0e5
to
f97da73
Compare
The following is the coverage report on pkg/.
|
f97da73
to
f151a9d
Compare
The following is the coverage report on pkg/.
|
f151a9d
to
cf718b9
Compare
The following is the coverage report on pkg/.
|
cf718b9
to
5d2e5d3
Compare
The following is the coverage report on pkg/.
|
5d2e5d3
to
bd5b2fb
Compare
The following is the coverage report on pkg/.
|
/test pull-tekton-pipeline-build-tests |
/test pull-tekton-pipeline-integration-tests |
2 similar comments
/test pull-tekton-pipeline-integration-tests |
/test pull-tekton-pipeline-integration-tests |
@sbwsg can you please review this PR? |
Kubeconfigwriter needs to improved to replace pipeline resource type "cluster" with thekubeconfig-creatortask. In order to do that, some extra configurations (e.g. client-key-data, client-certificate-data) needs to be added with some changes in the implementation. Signed-off-by: Divyansh42 <[email protected]>
bd5b2fb
to
1cdc6fa
Compare
The following is the coverage report on pkg/.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Kubeconfigwriter needs to improved to replace pipeline resource type "cluster" with the kubeconfig-creator task.
In order to do that, some extra configurations (e.g. client-key-data, client-certificate-data) needs to be added with some changes in the implementation.
Ref: [https://github.com/tektoncd/catalog/issues/95], [https://github.com/tektoncd/catalog/pull/251]
Closed prevoius PR #2338, due to some unrecoverable mistakes in the code.
Signed-off-by: Divyansh42 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes