Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement in the kubeconfigwriter #2366

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Improvement in the kubeconfigwriter #2366

merged 1 commit into from
Apr 14, 2020

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Apr 10, 2020 •
edited
Loading

Changes

Kubeconfigwriter needs to improved to replace pipeline resource type "cluster" with the kubeconfig-creator task.
In order to do that, some extra configurations (e.g. client-key-data, client-certificate-data) needs to be added with some changes in the implementation.

Ref: [https://github.com/tektoncd/catalog/issues/95], [https://github.com/tektoncd/catalog/pull/251]

Closed prevoius PR #2338, due to some unrecoverable mistakes in the code.

Signed-off-by: Divyansh42 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Added two more configurations in the Resource struct, those are:
- ClientKeyData
- ClientCertificateData

This change will allow user to access the cluster without using token or password,  provided they will have to use ClientKeyData and ClientCertificateData.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2020
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 10, 2020
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 10, 2020
@tekton-robot
Copy link
Collaborator

Hi @divyansh42. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2020
@ghost
Copy link

ghost commented Apr 10, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4

@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 12, 2020
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.7% 89.5% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.7% 89.5% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.7% 89.5% 0.8

@divyansh42
Copy link
Member Author

/test pull-tekton-pipeline-build-tests

@divyansh42
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

2 similar comments
@divyansh42
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@divyansh42
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@divyansh42
Copy link
Member Author

@sbwsg can you please review this PR?

ghost
ghost reviewed Apr 13, 2020
View reviewed changes
docs/resources.md Outdated Show resolved Hide resolved
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go Show resolved Hide resolved
cmd/kubeconfigwriter/main.go Show resolved Hide resolved
@divyansh42
Improvement in the kubeconfigwriter
1cdc6fa 
Kubeconfigwriter needs to improved to replace pipeline resource type "cluster" with thekubeconfig-creatortask.
In order to do that, some extra configurations (e.g. client-key-data, client-certificate-data) needs to be added with some changes in the implementation.

Signed-off-by: Divyansh42 <[email protected]>
@tekton-robot
Copy link
Collaborator

The following is the coverage report on pkg/.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/resource/v1alpha1/cluster/cluster_resource.go 75.7% 79.1% 3.4
pkg/apis/resource/v1alpha1/pipelineresource_validation.go 88.7% 89.5% 0.8

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2020
@divyansh42 divyansh42 changed the title WIP: Improvement in the kubeconfigwriter Improvement in the kubeconfigwriter Apr 14, 2020
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 14, 2020
vdemeester
vdemeester approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 4c5f1d5 into tektoncd:master Apr 14, 2020
@divyansh42 divyansh42 deleted the div-kubeconfigwriter-impr branch April 14, 2020 08:12
@divyansh42 divyansh42 mentioned this pull request Apr 17, 2020
Merged
3 tasks
@afrittoli afrittoli added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@divyansh42 @tekton-robot @vdemeester @afrittoli @googlebot