Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not automatically copy inputs used also as outputs #1118

Closed
dlorenc opened this issue Jul 23, 2019 · 1 comment · Fixed by #1122
Closed

Do not automatically copy inputs used also as outputs #1118

dlorenc opened this issue Jul 23, 2019 · 1 comment · Fixed by #1122
Assignees
@bobcatfish
Milestone
Pipelines 0.7 🐱

Comments

@dlorenc
Copy link
Contributor

dlorenc commented Jul 23, 2019

When the same resource is used as both an input and output to a Task, we copy the resulting information directly from the input path:

/workspace/$resource

rather than copying it from the /workspace/output/$resource directory. This causes a few problems:

  • Task implementations should not need to know whether they are called with the same resource as an input and output. They should behave the same in either case.
  • The logic to determine where to copy outputs from is more complicated and brittle.

This issue tracks the breaking change that makes this behavior consistent. Outputs are always only copied from the /workspace/outputs directory.
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 23, 2019

Ref #1076

@dlorenc dlorenc mentioned this issue Sep 5, 2019
Merged
3 tasks
@bobcatfish bobcatfish changed the title Breaking change to behavior of resource chaining Do not automatically copy inputs used also as outputs Sep 5, 2019
@bobcatfish bobcatfish self-assigned this Sep 5, 2019
@bobcatfish bobcatfish added this to the Pipelines 0.7 🐱 milestone Sep 5, 2019
dibyom added a commit to dibyom/triggers that referenced this issue Oct 8, 2019
@dibyom
Fix release task by copying input bucket contents
e2c1d90 
Pipeline 0.7 does not automatically copy input contents to
the output folder for resources that are used both as input as
well as output. See tektoncd/pipeline#1118.

This change updates the release publish task to manually copy over
the contents of the input release bucket.

Signed-off-by: Dibyo Mukherjee <[email protected]>
@dibyom dibyom mentioned this issue Oct 8, 2019
Merged
tekton-robot pushed a commit to tektoncd/triggers that referenced this issue Oct 8, 2019
@dibyom @tekton-robot
Fix release task by copying input bucket contents
4ffc356 
Pipeline 0.7 does not automatically copy input contents to
the output folder for resources that are used both as input as
well as output. See tektoncd/pipeline#1118.

This change updates the release publish task to manually copy over
the contents of the input release bucket.

Signed-off-by: Dibyo Mukherjee <[email protected]>
vdemeester pushed a commit to openshift/tektoncd-triggers that referenced this issue Nov 7, 2019
@dibyom @tekton-robot
Fix release task by copying input bucket contents
03e68c3 
Pipeline 0.7 does not automatically copy input contents to
the output folder for resources that are used both as input as
well as output. See tektoncd/pipeline#1118.

This change updates the release publish task to manually copy over
the contents of the input release bucket.

Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobcatfish bobcatfish

Labels
None yet
Projects
None yet
Milestone
Pipelines 0.7 🐱
Development

Successfully merging a pull request may close this issue.

Change the behavior of outputs that are also used as inputs. dlorenc/build-pipeline
2 participants
@bobcatfish @dlorenc