Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release task by copying input bucket contents #154

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Oct 8, 2019

Changes

Pipeline 0.7 does not automatically copy input contents to
the output folder for resources that are used both as input as
well as output. See tektoncd/pipeline#1118.

This change updates the release publish task to manually copy over
the contents of the input release bucket. Without this, we'll replace the contents
of the bucket each time.

Pipeline 0.7 does not automatically copy input contents to
the output folder for resources that are used both as input as
well as output. See tektoncd/pipeline#1118.

This change updates the release publish task to manually copy over
the contents of the input release bucket.

Signed-off-by: Dibyo Mukherjee <[email protected]>
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2019
@dibyom dibyom requested a review from vtereso October 8, 2019 20:12
@vtereso
Copy link

vtereso commented Oct 8, 2019

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vtereso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@tekton-robot tekton-robot merged commit 4ffc356 into tektoncd:master Oct 8, 2019
@dibyom dibyom deleted the release-task branch November 15, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants