Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow unknown keys in feature-flags configmap #6938

Open
lbernick opened this issue Jul 18, 2023 · 3 comments
Open

Disallow unknown keys in feature-flags configmap #6938

lbernick opened this issue Jul 18, 2023 · 3 comments
Assignees
@minhoryang
Labels
Hacktoberfest Categorizes issue as one for Hacktoberfest 2021 help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@lbernick
Copy link
Member

Currently, we don't perform any validation of the feature flags configmap. #6935 adds validation for keys representing existing feature flags, but it's still possible to misspell a feature flag or add a flag that's no longer supported, thinking it has an effect (example: #6937). We should validate that the configmap doesn't contain any unknown keys. We will probably need to fix #4542 first, otherwise upgrades will cause problems if we remove feature flags.
@afrittoli afrittoli added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 4, 2023
@afrittoli afrittoli added the Hacktoberfest Categorizes issue as one for Hacktoberfest 2021 label Oct 4, 2023
@minhoryang
Copy link
Contributor

I would like to work on this.

@minhoryang
Copy link
Contributor

AFAIK, I should cover this: pkg/apis/config/feature_flags.go, but should I cover this also pkg/apis/config/resolver/feature_flags.go?

minhoryang added a commit to minhoryang/tektoncd-pipeline that referenced this issue Oct 13, 2023
@minhoryang
tektoncd#6938 Disallow unknown keys in feature-flags configmap
d3ea595
@minhoryang
Copy link
Contributor

/assign @minhoryang

@minhoryang minhoryang mentioned this issue Oct 13, 2023
Closed
5 tasks
minhoryang added a commit to minhoryang/tektoncd-pipeline that referenced this issue Oct 19, 2023
@minhoryang
pick d3ea595 tektoncd#6938 Disallow unknown keys in feature-flags con…
0bb46e0 
…figmap

Signed-off-by: Minho Ryang <[email protected]>
minhoryang added a commit to minhoryang/tektoncd-pipeline that referenced this issue Oct 19, 2023
@minhoryang
tektoncd#6938 Disallow unknown keys in feature-flags configmap via kn…
a3de409 
…own keys

Signed-off-by: Minho Ryang <[email protected]>
minhoryang added a commit to minhoryang/tektoncd-pipeline that referenced this issue Oct 22, 2023
@minhoryang
tektoncd#6938 Disallow unknown keys in feature-flags configmap
5553d54 
Signed-off-by: Minho Ryang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minhoryang minhoryang

Labels
Hacktoberfest Categorizes issue as one for Hacktoberfest 2021 help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@minhoryang @afrittoli @lbernick