-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for feature-flags configmap to webhook #6935
Conversation
Prior to this commit, the validating admission webhook validated the logging, defaults, and leader election configmaps, but not the feature flags configmap. This meant that invalid edits to the feature-flags configmap would be silently accepted, but could later cause PipelineRuns and TaskRuns to fail. This commit validates the feature-flags configmap in the validation webhook. Note: we currently have a cyclic dependency between the validating admission webhook and the configmaps used by pipelines. This commit does not address this problem, which should be handled separately (tektoncd#4542).
/assign |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test check-pr-has-kind-label |
@lbernick: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Prior to this commit, the validating admission webhook validated the logging, defaults, and leader election configmaps, but not the feature flags configmap. This meant that invalid edits to the feature-flags configmap would be silently accepted, but could later cause PipelineRuns and TaskRuns to fail. This commit validates the feature-flags configmap in the validation webhook.
Note: we currently have a cyclic dependency between the validating admission webhook and the configmaps used by pipelines. This commit does not address this problem, which should be handled separately (#4542).
Tested locally.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes