Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0075]Add more setdefaults features for taskresults #5142

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[TEP-0075]Add more setdefaults features for taskresults #5142

merged 1 commit into from
Jul 28, 2022

Conversation

Yongxuanzhang
Copy link
Member

@Yongxuanzhang Yongxuanzhang commented Jul 14, 2022 •
edited
Loading

Changes

This commit add more feature for TaskResult's SetDefaults, if the
Properties is set then the result type is inferred as object. For Properties
value it is also set to string by default.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

taskresults is inferred as object if Properties is set, and Properties's value by default is string

@tekton-robot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2022
@Yongxuanzhang
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Jul 14, 2022
@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review July 14, 2022 19:34
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2022
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/result_defaults.go 100.0% 88.9% -11.1

@Yongxuanzhang Yongxuanzhang mentioned this pull request Jul 19, 2022
Merged
7 tasks
@ywluogg
Copy link
Contributor

ywluogg commented Jul 19, 2022

/assign @ywluogg

@ywluogg
Copy link
Contributor

ywluogg commented Jul 21, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2022
@lbernick
Copy link
Member

Can you please add these changes to the v1 package as well?

@Yongxuanzhang
[TEP-0075]Add more setdefaults features for taskresults
096db8f 
This commit add more feature for TaskResult's SetDefaults, if the
Properties is set then the result type is inferred as object. For Properties
value type it is also set to string by default.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@Yongxuanzhang
Copy link
Member Author

Can you please add these changes to the v1 package as well?

Just added!

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@ywluogg
Copy link
Contributor

ywluogg commented Jul 28, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@tekton-robot tekton-robot merged commit 2f93ab2 into tektoncd:main Jul 28, 2022
@Yongxuanzhang Yongxuanzhang mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuangw6 chuangw6 chuangw6 left review comments

@lbernick lbernick lbernick approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

@abayer abayer Awaiting requested review from abayer

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@ywluogg ywluogg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yongxuanzhang @tekton-robot @ywluogg @lbernick @chuangw6