Add validation for results object properties types #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
size/M
|
/kind feature |
tekton-robot
added
the
kind/feature
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/hold until #5142 merged |
tekton-robot
added
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
Yongxuanzhang
force-pushed
the
validate-object-properties
branch
from
d1335be
to
9c68c3f
Compare
tekton-robot
added
size/L
Yongxuanzhang
force-pushed
the
validate-object-properties
branch
from
9c68c3f
to
7287408
Compare
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
lbernick
reviewed
Jul 28, 2022
Yongxuanzhang
force-pushed
the
validate-object-properties
branch
from
7287408
to
9d0f9b8
Compare
This commit adds the validation for results object properties types. Right now we only support string types, so if the type is not string we should validate and return err for this.
Yongxuanzhang
force-pushed
the
validate-object-properties
branch
from
9d0f9b8
to
c19aa83
Compare
|
/retest |
1 similar comment
|
/retest |
lbernick
approved these changes
Jul 29, 2022
Comment on lines
+57
to
+58
| // validateObjectResult validates the object result and check if the Properties is missing | ||
| // for Properties values it will check if the type is string. |
There was a problem hiding this comment.
Suggested change
| // validateObjectResult validates the object result and check if the Properties is missing | |
| // for Properties values it will check if the type is string. | |
| // validateObjectResult validates that the object result has Properties, | |
| // and that all Properties are strings. |
There was a problem hiding this comment.
Also, is there a reason PropertySpec has a type if the only supported type is string?
There was a problem hiding this comment.
yeah it is required in tep75 and I think the reason is to support future extension
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ywluogg
reviewed
Jul 29, 2022
|
|
||
| if len(invalidKeys) != 0 { | ||
| return &apis.FieldError{ | ||
| Message: fmt.Sprintf("The value type specified for these keys %v is invalid, the type must be string", invalidKeys), |
There was a problem hiding this comment.
Suggested change
| Message: fmt.Sprintf("The value type specified for these keys %v is invalid, the type must be string", invalidKeys), | |
| Message: fmt.Sprintf("The value type specified for these keys %v are invalid, the type must be string", invalidKeys), |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds the validation for results object properties types.
Right now we only support string types, so if the type is not string we
should validate and return err for this.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes