Move parameter validation from `taskspec` to `taskrunspec` when propagating parameters #5143

chitrangpatel · 2022-07-14T19:49:52Z

Prior to this, propagating parameters only skipped webhook validation
for params defined in script. As a result, when users tried to propagate
params to other fields like args or command, etc. an webhook
validation was raised. This PR address issue #5141.
This PR addresses validations in taskspec and taskrunspec. The changes for validations in pipelinespec and pipelinerunspec will be added in a follow up PR.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Move parameter validation from `taskspec` to `taskrunspec` when propagating parameters

chitrangpatel · 2022-07-14T19:52:11Z

/kind bug

chitrangpatel · 2022-07-14T19:52:46Z

cc @chuangw6

tekton-robot · 2022-07-14T19:55:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/task_validation.go	97.6%	97.6%	0.0

pkg/apis/pipeline/v1beta1/task_validation.go

tekton-robot · 2022-07-15T19:54:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	100.0%	81.7%	-18.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go	100.0%	92.9%	-7.1

tekton-robot · 2022-07-15T20:06:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	100.0%	95.0%	-5.0
pkg/apis/pipeline/v1beta1/taskrun_validation.go	100.0%	98.0%	-2.0

chitrangpatel · 2022-07-15T20:10:06Z

/retest

tekton-robot · 2022-07-15T20:19:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	100.0%	96.7%	-3.3
pkg/apis/pipeline/v1beta1/taskrun_validation.go	100.0%	99.0%	-1.0

jerop · 2022-08-02T20:45:23Z

/retest

pkg/apis/pipeline/v1/task_validation.go

pkg/apis/pipeline/v1beta1/taskrun_validation.go

pkg/reconciler/taskrun/taskrun.go

pkg/apis/pipeline/v1beta1/task_validation_test.go

JeromeJu · 2022-08-03T14:16:20Z

After discussion with @JeromeJu, I think I will break this PR into handling task validations and pipeline validations separately so that v1 and v1beta1 can be kept in sync. For now, I will only open a PR for task validations. Once #5219 is merged, I will sync my changes to the pipeline validations and open a PR for it.

Thanks Chitrang!

tekton-robot · 2022-08-03T17:31:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.6%	80.7%	0.1

tekton-robot · 2022-08-03T18:08:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.6%	80.7%	0.1

pkg/apis/pipeline/v1/task_validation_test.go

pkg/apis/pipeline/v1beta1/taskrun_validation.go

pkg/apis/pipeline/v1beta1/taskrun_validation_test.go

tekton-robot · 2022-08-08T21:03:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.6%	80.7%	0.1

tekton-robot · 2022-08-08T21:23:13Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.6%	80.7%	0.1

tekton-robot · 2022-08-09T14:01:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.6%	80.7%	0.1

tekton-robot · 2022-08-09T14:22:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.6%	80.7%	0.1

pkg/apis/pipeline/v1beta1/taskrun_validation.go

pkg/apis/pipeline/v1beta1/taskrun_validation_test.go

…ameters Prior to this, propagating parameters only skipped webhook validation for params defined in script. As a result, when users tried to propagate params to other fields like `args` or `command`, etc. an webhook validation was raised. This PR address this issue.

tekton-robot · 2022-08-11T19:40:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.1%	98.0%	0.8
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.1%	0.8
pkg/reconciler/taskrun/taskrun.go	80.3%	80.3%	0.1

lbernick · 2022-08-11T19:49:43Z

/lgtm

jerop · 2022-08-11T20:03:48Z

TestPipelineRunTimeout again 🙃

/retest

tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2022

tekton-robot requested review from abayer and pritidesai July 14, 2022 19:50

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2022

tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 14, 2022

chuangw6 reviewed Jul 14, 2022

View reviewed changes

pkg/apis/pipeline/v1beta1/task_validation.go Outdated Show resolved Hide resolved

chitrangpatel marked this pull request as draft July 15, 2022 13:45

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from d987b78 to 8cb7c26 Compare July 15, 2022 19:28

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2022

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 8cb7c26 to 6bd7552 Compare July 15, 2022 19:49

chitrangpatel marked this pull request as ready for review July 15, 2022 19:49

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2022

tekton-robot requested a review from vdemeester July 15, 2022 19:49

chitrangpatel changed the title ~~Skip validation when propagating parameters~~ Move validation from taskspec to taskrunspec when propagating parameters Jul 15, 2022

chitrangpatel changed the title ~~Move validation from taskspec to taskrunspec when propagating parameters~~ Move parameter validation from taskspec to taskrunspec when propagating parameters Jul 15, 2022

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch 2 times, most recently from b1b87e2 to b82a2ab Compare July 15, 2022 20:02

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from b82a2ab to c9ed2eb Compare July 15, 2022 20:15

chitrangpatel marked this pull request as draft July 16, 2022 14:23

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022

lbernick reviewed Aug 2, 2022

View reviewed changes

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 745925f to 412259e Compare August 3, 2022 17:27

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 412259e to 658de84 Compare August 3, 2022 18:05

JeromeJu mentioned this pull request Aug 3, 2022

Add V1 TaskRun Golang structs #5264

Merged

5 tasks

chitrangpatel requested a review from lbernick August 8, 2022 13:58

lbernick reviewed Aug 8, 2022

View reviewed changes

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 658de84 to 04f8ed4 Compare August 8, 2022 20:58

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 04f8ed4 to 3e446f0 Compare August 8, 2022 21:18

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 3e446f0 to befdb86 Compare August 9, 2022 13:56

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from befdb86 to 4c3bebd Compare August 9, 2022 14:17

chitrangpatel mentioned this pull request Aug 9, 2022

Move validation from pipelinespec to pipelinerunspec when propagating parameters #5291

Merged

7 tasks

lbernick reviewed Aug 11, 2022

View reviewed changes

chitrangpatel force-pushed the Bugfix-5141-propagating-params-for-args branch from 4c3bebd to fd9f6c3 Compare August 11, 2022 19:33

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022

tekton-robot merged commit 57aa030 into tektoncd:main Aug 11, 2022

jerop mentioned this pull request Aug 15, 2022

TEP0107 - Parameter propagation doesn't work for taskSpec-steps-args #5141

Closed

chitrangpatel mentioned this pull request Aug 24, 2022

Propagating object params #5371

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move parameter validation from `taskspec` to `taskrunspec` when propagating parameters #5143

Move parameter validation from `taskspec` to `taskrunspec` when propagating parameters #5143

chitrangpatel commented Jul 14, 2022 •

edited

Loading

chitrangpatel commented Jul 14, 2022

chitrangpatel commented Jul 14, 2022

tekton-robot commented Jul 14, 2022

tekton-robot commented Jul 15, 2022

tekton-robot commented Jul 15, 2022

chitrangpatel commented Jul 15, 2022

tekton-robot commented Jul 15, 2022

jerop commented Aug 2, 2022

JeromeJu commented Aug 3, 2022

tekton-robot commented Aug 3, 2022

tekton-robot commented Aug 3, 2022

tekton-robot commented Aug 8, 2022

tekton-robot commented Aug 8, 2022

tekton-robot commented Aug 9, 2022

tekton-robot commented Aug 9, 2022

tekton-robot commented Aug 11, 2022

lbernick commented Aug 11, 2022

jerop commented Aug 11, 2022

Move parameter validation from taskspec to taskrunspec when propagating parameters #5143

Move parameter validation from taskspec to taskrunspec when propagating parameters #5143

Conversation

chitrangpatel commented Jul 14, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

chitrangpatel commented Jul 14, 2022

chitrangpatel commented Jul 14, 2022

tekton-robot commented Jul 14, 2022

tekton-robot commented Jul 15, 2022

tekton-robot commented Jul 15, 2022

chitrangpatel commented Jul 15, 2022

tekton-robot commented Jul 15, 2022

jerop commented Aug 2, 2022

JeromeJu commented Aug 3, 2022

tekton-robot commented Aug 3, 2022

tekton-robot commented Aug 3, 2022

tekton-robot commented Aug 8, 2022

tekton-robot commented Aug 8, 2022

tekton-robot commented Aug 9, 2022

tekton-robot commented Aug 9, 2022

tekton-robot commented Aug 11, 2022

lbernick commented Aug 11, 2022

jerop commented Aug 11, 2022

Move parameter validation from `taskspec` to `taskrunspec` when propagating parameters #5143

Move parameter validation from `taskspec` to `taskrunspec` when propagating parameters #5143

chitrangpatel commented Jul 14, 2022 •

edited

Loading