Add V1 TaskRun Golang structs #5264

JeromeJu · 2022-08-03T15:13:57Z

Changes

This commit adds structs and validation for v1 TaskRun, including params,
resultRef and workspaces. This is copied from v1beta1 with the following exceptions:

omitted TaskRunResources
- This includes the TaskRunInputs and TaskRunOutputs and respective test
omitted CloudEventDeliveryState
renamed the Go fields of StepState.ContainerName to StepState.Containerand
SidecarState.ContainerName to SidecarState.Container but not the api fields
renamed taskResults to results

Part of #4985
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[n/a] Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2022-08-03T15:13:59Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tekton-robot · 2022-08-10T15:26:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/pod.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

tekton-robot · 2022-08-10T18:14:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/pod.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

pkg/apis/pipeline/v1/taskref_types.go

pkg/apis/pipeline/v1/pod.go

pkg/apis/pipeline/v1/taskrun_types.go

tekton-robot · 2022-08-11T21:08:27Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/pod.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	0.0%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

tekton-robot · 2022-08-12T15:53:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/pod.go	Do not exist	75.0%
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	100.0%

tekton-robot · 2022-08-15T20:14:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/pod.go	Do not exist	75.0%
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	100.0%

pkg/apis/pipeline/v1/taskrun_types.go

pkg/apis/pipeline/v1/taskrun_types_test.go

tekton-robot · 2022-08-19T17:02:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2022-08-19T17:18:55Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

tekton-robot · 2022-08-23T18:19:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

jerop

/retest

tekton-robot · 2022-08-24T13:00:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

tekton-robot · 2022-08-24T13:22:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

tekton-robot · 2022-08-24T13:48:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

JeromeJu · 2022-08-24T14:34:25Z

As this is a large PR and the changes are copied from v1beta1, put this PR for visualization for easier comparison.

tekton-robot · 2022-08-24T14:52:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

dibyom · 2022-08-24T15:53:14Z

This LGTM. Can you squash up the commits?

tekton-robot · 2022-08-24T17:59:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

This commit adds structs and validation for v1 TaskRun, including params, resultRef and workspaces. This is copied from v1beta1 with the following exceptions: - omitted TaskRunResources - This includes the `TaskRunInputs` and `TaskRunOutputs` and respective test - omitted `CloudEvents` related fields including `CloudEventDeliveryState` - renamed the Go fields of `StepState.ContainerName` to `StepState.Container`and `SidecarState.ContainerName` to `SidecarState.Container` but not the api fields - renamed `taskResults` to `results`

tekton-robot · 2022-08-24T18:06:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/apis/pipeline/v1/taskrun_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskrun_types.go	Do not exist	77.2%
pkg/apis/pipeline/v1/taskrun_validation.go	Do not exist	0.0%

JeromeJu · 2022-08-24T18:39:37Z

Thanks @dibyom, squashed and retested.

abayer · 2022-08-24T20:47:12Z

/lgtm

pkg/apis/pipeline/v1/taskrun_validation_test.go

tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. labels Aug 3, 2022

tekton-robot requested review from dlorenc and pritidesai August 3, 2022 15:14

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 3, 2022

JeromeJu force-pushed the 4985-v1-taskrun branch from 3768da8 to 28a6ce2 Compare August 3, 2022 18:23

JeromeJu changed the title ~~[WIP] Add V1 TaskRun Golang structs~~ Add V1 TaskRun Golang structs Aug 4, 2022

lbernick self-assigned this Aug 8, 2022

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2022

JeromeJu force-pushed the 4985-v1-taskrun branch from 28a6ce2 to 0d22419 Compare August 9, 2022 19:04

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2022

JeromeJu force-pushed the 4985-v1-taskrun branch from 0d22419 to b55e219 Compare August 10, 2022 15:11

JeromeJu marked this pull request as ready for review August 10, 2022 15:12

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2022

tekton-robot requested review from afrittoli and bobcatfish August 10, 2022 15:12

JeromeJu force-pushed the 4985-v1-taskrun branch from b55e219 to a3fb582 Compare August 10, 2022 15:22

lbernick reviewed Aug 11, 2022

View reviewed changes

JeromeJu mentioned this pull request Aug 12, 2022

Refactor pipeline related function in taskrun_types.go #5320

Closed

JeromeJu force-pushed the 4985-v1-taskrun branch from ce34e4c to f584deb Compare August 15, 2022 20:09

JeromeJu requested a review from lbernick August 15, 2022 21:13

JeromeJu force-pushed the 4985-v1-taskrun branch 2 times, most recently from b3d80ea to 9a75b5a Compare August 16, 2022 18:38

lbernick approved these changes Aug 19, 2022

View reviewed changes

pkg/apis/pipeline/v1/taskrun_types.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/taskrun_types_test.go Outdated Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022

JeromeJu force-pushed the 4985-v1-taskrun branch from b609471 to 38acbc0 Compare August 19, 2022 17:14

JeromeJu requested a review from afrittoli August 19, 2022 17:18

JeromeJu force-pushed the 4985-v1-taskrun branch from 38acbc0 to 5d80bc2 Compare August 23, 2022 18:14

jerop reviewed Aug 23, 2022

View reviewed changes

JeromeJu force-pushed the 4985-v1-taskrun branch from 5d80bc2 to 1596a86 Compare August 24, 2022 12:55

JeromeJu requested review from jerop and removed request for afrittoli August 24, 2022 14:15

JeromeJu force-pushed the 4985-v1-taskrun branch from 05879df to 52557b1 Compare August 24, 2022 17:55

JeromeJu force-pushed the 4985-v1-taskrun branch from 52557b1 to 86c860d Compare August 24, 2022 18:02

tekton-robot assigned abayer Aug 24, 2022

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022

tekton-robot merged commit 7843f99 into tektoncd:main Aug 24, 2022

chitrangpatel reviewed Aug 26, 2022

View reviewed changes

pkg/apis/pipeline/v1/taskrun_validation_test.go Show resolved Hide resolved

JeromeJu mentioned this pull request Jan 16, 2023

Handle PipelineResources when swapping v1 to the storage version #5967

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add V1 TaskRun Golang structs #5264

Add V1 TaskRun Golang structs #5264

JeromeJu commented Aug 3, 2022 •

edited

Loading

tekton-robot commented Aug 3, 2022

tekton-robot commented Aug 10, 2022

tekton-robot commented Aug 10, 2022

tekton-robot commented Aug 11, 2022

tekton-robot commented Aug 12, 2022

tekton-robot commented Aug 15, 2022

tekton-robot commented Aug 19, 2022

tekton-robot commented Aug 19, 2022

tekton-robot commented Aug 23, 2022

jerop left a comment

tekton-robot commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

JeromeJu commented Aug 24, 2022 •

edited

Loading

tekton-robot commented Aug 24, 2022

dibyom commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

JeromeJu commented Aug 24, 2022

abayer commented Aug 24, 2022

Add V1 TaskRun Golang structs #5264

Add V1 TaskRun Golang structs #5264

Conversation

JeromeJu commented Aug 3, 2022 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Aug 3, 2022

tekton-robot commented Aug 10, 2022

tekton-robot commented Aug 10, 2022

tekton-robot commented Aug 11, 2022

tekton-robot commented Aug 12, 2022

tekton-robot commented Aug 15, 2022

tekton-robot commented Aug 19, 2022

tekton-robot commented Aug 19, 2022

tekton-robot commented Aug 23, 2022

jerop left a comment

Choose a reason for hiding this comment

tekton-robot commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

JeromeJu commented Aug 24, 2022 • edited Loading

tekton-robot commented Aug 24, 2022

dibyom commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

tekton-robot commented Aug 24, 2022

JeromeJu commented Aug 24, 2022

abayer commented Aug 24, 2022

JeromeJu commented Aug 3, 2022 •

edited

Loading

JeromeJu commented Aug 24, 2022 •

edited

Loading