Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v1 PipelineRun CRD conversionReviewVersions and conversion typo #5619

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Oct 7, 2022

Changes

This change adds the v1 conversionReviewVersion for v1 for pipelineRun CRD
and fixes the typo for pipelineRun conversion.

/kind bug
cc @lbernick

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • [n/a] Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • [n/a] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • [n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 7, 2022
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 7, 2022
@JeromeJu JeromeJu changed the title Fix conversionReviewVersions Fix v1 PipelineRun conversion Oct 7, 2022
Copy link
Member

@lbernick lbernick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jerome! Can you please add a more descriptive PR title/commit message?

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lbernick,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester vdemeester self-requested a review October 10, 2022 15:06
@vdemeester
Copy link
Member

That said, doesn't it depend on #5579 ? (aka what happens if the conversion webhook has this v1 in its configuration but there is no v1 on the cluster ?)

@dibyom
Copy link
Member

dibyom commented Oct 10, 2022

(aka what happens if the conversion webhook has this v1 in its configuration but there is no v1 on the cluster ?)

the v1 version exists, it just is not "served" by the API server yet. #5579 flips the bit to start serving our v1 version

@JeromeJu JeromeJu changed the title Fix v1 PipelineRun conversion Fix v1 PipelineRun CRD conversionReviewVersions and conversion typo Oct 11, 2022
@tekton-robot
Copy link
Collaborator

The following Tekton test failed:

Test name Commit Details Required Rerun command
check-pr-has-kind-label 0ca4c7a link true /test check-pr-has-kind-label

@abayer
Copy link
Contributor

abayer commented Oct 11, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2022
@tekton-robot tekton-robot merged commit e9e4cd6 into tektoncd:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants