-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ImagePullTimeout to use "Initialized" #7882
Conversation
ImagePullBackOffTimeOut currently uses the "Scheduled" pod condition transition time, however a pod can be scheduled on a node far earlier than when image pulling begins which can (and does) result in Tasks failing when image pulls could be retried and succeed. We should use the transition time for "PodReadyToStartContainers" (1.29+) / "Initialized" for checking the image pull timeout as these conditions more accurately capture when the image pull began. This commit updates this logic and adds the covering tests.
/kind bug |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm thank you @skaegi 👍 |
Fixes #7881.
ImagePullBackOffTimeOut currently uses the "Scheduled" pod condition transition time, however a pod can be scheduled on a node far earlier than when image pulling begins which can (and does) result in Tasks failing when image pulls could be retried and succeed.
We should use the transition time for "PodReadyToStartContainers" (1.29+) / "Initialized" for checking the image pull timeout as these conditions more accurately capture when the image pull began.
Changes
This commit updates the imagePullBackOffTimeOut logic to use the "PodInitialized" or "PodReadyToStartContainers" Pod Condition in favour of "PodScheduled" and adds the covering tests.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes