Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ImagePullTimeout to use "Initialized" #7882

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix ImagePullTimeout to use "Initialized" #7882

merged 1 commit into from
Apr 15, 2024

Commits on Apr 14, 2024

  1. Fix ImagePullTimeout to use "Initialized" 

    ImagePullBackOffTimeOut currently uses the "Scheduled" pod condition transition time, however a pod can be scheduled on a node far earlier than when image pulling begins which can (and does) result in Tasks failing when image pulls could be retried and succeed.

We should use the transition time for "PodReadyToStartContainers" (1.29+) / "Initialized" for checking the image pull timeout as these conditions more accurately capture when the image pull began. This commit updates this logic and adds the covering tests.
    @skaegi
    skaegi committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    e49587f View commit details
    Browse the repository at this point in the history