Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestMatcherSuite/TestMustOfferRemoteMatch is flaky #243

Closed
samarabbas opened this issue Mar 21, 2020 · 0 comments · Fixed by #654
Closed

TestMatcherSuite/TestMustOfferRemoteMatch is flaky #243

samarabbas opened this issue Mar 21, 2020 · 0 comments · Fixed by #654
Assignees
@mastermanu
Labels
flaky-test

Comments

@samarabbas
Copy link
Contributor

samarabbas commented Mar 21, 2020 •
edited by alexshtin
Loading 

=== RUN   TestMatcherSuite/TestMustOfferRemoteMatch
    TestMatcherSuite/TestMustOfferRemoteMatch: matcher_test.go:404: 
        	Error Trace:	matcher_test.go:404
        	Error:      	Expected value not to be nil.
        	Test:       	TestMatcherSuite/TestMustOfferRemoteMatch
    TestMatcherSuite/TestMustOfferRemoteMatch: matcher_test.go:406: 
        	Error Trace:	matcher_test.go:406
        	Error:      	Should be true
        	Test:       	TestMatcherSuite/TestMustOfferRemoteMatch
    TestMatcherSuite/TestMustOfferRemoteMatch: matcher_test.go:407: 
        	Error Trace:	matcher_test.go:407
        	Error:      	Should be true
        	Test:       	TestMatcherSuite/TestMustOfferRemoteMatch
    TestMatcherSuite/TestMustOfferRemoteMatch: matcher_test.go:408: 
        	Error Trace:	matcher_test.go:408
        	Error:      	Not equal: 
        	            	expected: "/__temporal_sys/tl0/1"
        	            	actual  : ""
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-/__temporal_sys/tl0/1
        	            	+
        	Test:       	TestMatcherSuite/TestMustOfferRemoteMatch
    TestMatcherSuite/TestMustOfferRemoteMatch: matcher_test.go:409: 
        	Error Trace:	matcher_test.go:409
        	Error:      	Not equal: 
        	            	expected: "tl0"
        	            	actual  : ""
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-tl0
        	            	+
        	Test:       	TestMatcherSuite/TestMustOfferRemoteMatch
@alexshtin alexshtin mentioned this issue Jul 14, 2020
Closed
@alexshtin alexshtin changed the title Flaky unit test TestMatcherSuite/TestMustOfferRemoteMatch TestMatcherSuite/TestMustOfferRemoteMatch is flaky Jul 22, 2020
@mastermanu mastermanu assigned mastermanu and unassigned samarabbas Aug 4, 2020
@mastermanu mastermanu linked a pull request Aug 4, 2020 that will close this issue
Adds automatic population of unset retrypolicy field when starting Workflows #654
Merged
@mastermanu mastermanu mentioned this issue Aug 4, 2020
Merged
mastermanu added a commit that referenced this issue Aug 4, 2020
@mastermanu
Adds automatic population of unset retrypolicy field when starting Wo…
0ae59f6 
…rkflows (#654)

Change summary:

Adds a separate dynamic configuration to dictate "default" retry policy field values for Workflows vs. Activities
Adds logic to auto-populate unset retry policy fields for starting a workflow, signaling-to-starting a workflow, and starting a child workflow. If the specified retry policy is nil, no auto-population happens. If it is non-nil, unset fields are assigned defaults
Fixes bug where WorkflowExpirationTime was always set to 0 for Child Workflows. This meant that Child Workflows would assume that max attempts = 0 implies no retry policy is set.
Addresses flakiness in matching test (#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mastermanu mastermanu

Labels
flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds automatic population of unset retrypolicy field when starting Workflows mastermanu/temporal
3 participants
@samarabbas @alexshtin @mastermanu