-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds automatic population of unset retrypolicy field when starting Workflows #654
Conversation
// if a policy is explicitly set on a workflow | ||
type DefaultRetrySettings struct { | ||
InitialIntervalInSeconds int32 | ||
MaximumIntervalCoefficient float64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it called MaximumIntervalCoefficient
? I think we should just call it MaximumInterval
and use Duration as type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We needed to initialize maximum interval in the case maximum interval was not set by the user, but a default maximum value might be less than the initial interval, which would then fail validation.
Btw, this change is already part of code-complete (this is just moving code around) and Maxim and I walked through this specific choice to use Coefficient vs. Interval before we landed this (it was initially an Interval).
Happy to discuss offline if we want to make further changes here though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. You can land after addressing few minor comments.
It would be great if you can also add an integration test which covers default retry policies for activity and child workflows.
Change summary:
Validation:
Backwards compatibility:
Future work: