Add enforcement of namespace match for async completion tokens #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RespondActivityTaskCompleted * RespondActivityTaskFailed * RespondActivityTaskCanceled
* RespondWorkflowTaskCompleted * RespondWorkflowTaskFailed * RespondQueryTaskCompleted
* RespondWorkflowTaskCompleted * RespondWorkflowTaskFailed * RespondQueryTaskCompleted
alexshtin
reviewed
Dec 14, 2020
service/frontend/workflowHandler.go
Outdated
| if !wh.config.EnableTokenNamespaceEnforcement() { | ||
| return nil | ||
| } | ||
| if !strings.EqualFold(requestNamespace, tokenNamespace) { |
There was a problem hiding this comment.
Namespaces are case sensitive. At least I was able to create two namespaces which are different in case only. It means someone else might already have such namespaces created and this check will be backward compatible for them.
I think this should be regular string comparison.
There was a problem hiding this comment.
namespace is case sensitive
wxing1292
reviewed
Dec 14, 2020
service/frontend/workflowHandler.go
Outdated
Comment on lines
887
to
889
| func (wh *WorkflowHandler) RespondWorkflowTaskCompleted(ctx context.Context, | ||
| request *workflowservice.RespondWorkflowTaskCompletedRequest) (_ *workflowservice.RespondWorkflowTaskCompletedResponse, | ||
| retError error) { |
There was a problem hiding this comment.
func (wh *WorkflowHandler) RespondWorkflowTaskCompleted(
ctx context.Context,
request *workflowservice.RespondWorkflowTaskCompletedRequest)
(_ *workflowservice.RespondWorkflowTaskCompletedResponse, retError error) {There was a problem hiding this comment.
I didn't want to start this, but yes, let's make some standart here. Seems like nor gofmt neither Go Land are not care much about it. So there are two cases:
- One line. All parameters are on the saneline, all return values are on the same line, no empty line before func body:
func convertString(input string) string {
return strings.ToUpper(input)
}- Many lines. Method/func name and all parameters are on separate line, each has comma at the end and there is a blank line before body. Return values are still on the same line though as we almost don't have more than 2:
func (wh *WorkflowHandler) RespondWorkflowTaskCompleted(
ctx context.Context,
request *workflowservice.RespondWorkflowTaskCompletedRequest,
) (_ *workflowservice.RespondWorkflowTaskCompletedResponse, retError error) {
defer ...
wxing1292
reviewed
Dec 14, 2020
service/frontend/workflowHandler.go
Outdated
Comment on lines
979
to
981
| func (wh *WorkflowHandler) RespondWorkflowTaskFailed(ctx context.Context, | ||
| request *workflowservice.RespondWorkflowTaskFailedRequest) (_ *workflowservice.RespondWorkflowTaskFailedResponse, | ||
| retError error) { |
wxing1292
reviewed
Dec 14, 2020
service/frontend/workflowHandler.go
Outdated
Comment on lines
1369
to
1371
| func (wh *WorkflowHandler) RespondActivityTaskCompleted(ctx context.Context, | ||
| request *workflowservice.RespondActivityTaskCompletedRequest) (_ *workflowservice.RespondActivityTaskCompletedResponse, | ||
| retError error) { |
wxing1292
suggested changes
Dec 14, 2020
alexshtin
approved these changes
Dec 15, 2020
wxing1292
approved these changes
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added enforcement of async completion tokens matching request's namespace.
Why?
Such mismatched (by mistake) calls caused customers' confusion and investigation.
Mismatched calls also violate isolation of namespaces.
How did you test it?
Unit tests.
Potential risks
No risk as the enforcement is disabled by default (for backward compatibility).