Turn on frontend.enableTokenNamespaceEnforcement by default #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Jan 11, 2023
yux0
pushed a commit
that referenced
this pull request
Jan 13, 2023
yux0
pushed a commit
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Change default for
frontend.enableTokenNamespaceEnforcementto true.Why?
This was added in #1086 but disabled by default for compatibility concerns. It's a useful security hardening feature, though. If this does break anyone now, they should fix their clients to send matching namespace fields, or upgrade SDKs.
How did you test it?
CI
Potential risks
Could possibly break some obscure uses. Cluster operators can turn it off if necessary.
Is hotfix candidate?