Skip to content
This repository has been archived by the owner on Jun 3, 2020. It is now read-only.

Feature request: improve key output #253

Closed
mdyring opened this issue May 14, 2019 · 3 comments
Closed

Feature request: improve key output #253

mdyring opened this issue May 14, 2019 · 3 comments

Comments

@mdyring
Copy link
Contributor

mdyring commented May 14, 2019

Currently tmkms yubihsm keys list outputs key information in hex format, that is hard to reconcile or use.

I'd like to suggest the following changes:

  1. Output the key label in tmkms yubihsm keys list to make intended use obvious.
  2. Introduce a tmkms chains list command that outputs keys in the expected format (bech32). It could display the chain-id, and then the formatted list of associated keys.
@tarcieri
Copy link
Contributor

The output was originally a bit better for cosmos, but regressed in #205. It'd be nice if it used chain-specific formatting logic if available.

tarcieri added a commit that referenced this issue Jun 24, 2019
…tters

yubihsm keys list: Use chain-specific formatters (fixes #253)
@tarcieri
Copy link
Contributor

I closed this in #275, implementing something close to the behavior before #205, which is to list keys in Bech32 with chain-specific prefixes when the configuration allows for this.

It should hopefully work almost all of the time, provided the KMS is properly configured. In the event it isn't, it will fall back on the hex representation (i.e. the current behavior).

@mdyring
Copy link
Contributor Author

mdyring commented Jun 25, 2019

Cool, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants