This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Initial chain registry (fixes #60, #178) #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
chain-registry
branch
from
eadd3b3
to
3b36d42
Compare
Adds a `chain::REGISTRY` (as a `lazy_static`) to tmkms, populated from the configuration file. Uses this registry when serializing keys to select the appropriate serialization format.
tarcieri
force-pushed
the
chain-registry
branch
from
3b36d42
to
ce31ad7
Compare
|
This commit makes breaking changes to the configuration format (namely adding a mandatory Not sure what the proper order is as far as merging this commit versus updating that... |
tarcieri
changed the title
This commit moves the last sign state tracking for chains into the global chain registry. It also allows configurable locations for the chain state tracking files, which should probably make it easier to ensure they don't clobber each other in tests. This doesn't fully implement the double signing plan in #60 but at this point I think we're close enough. The remaining item is (optionally) running a user-specified command on startup to query the current block height.
tarcieri
force-pushed
the
chain-registry
branch
from
4ee1a4a
to
31eaad1
Compare
Preparatory work for adding support for initializing the `last_sign` state from a user-specified hook.
Adds a new option to tmkms.toml `[chain]` entries:
[chain.state_hook]
cmd = ["/path/to/block/height_script", "--example-arg", "cosmoshub"]
This command is expected to return a JSON document like:
{"latest_block_height": "347290"}
If present, and larger than the latest known block height, this value
will be used instead (up to a pre-configured sanity limit).
The KMS configs need to be updated in Tendermint
tarcieri
force-pushed
the
chain-registry
branch
from
a773498
to
e1d356e
Compare
This was referenced Mar 10, 2019
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
chain::REGISTRY(as alazy_static) to tmkms, populated from the configuration file.Uses this registry when serializing keys to select the appropriate serialization format.
Also lays the ground work for fixing #111 by associating one or more chain IDs with each key (previously done in an ad hoc manner)