Base Dockerfiles for tfio #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
approved these changes
Aug 17, 2020
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
* added minimal cpu.Dockerfile and README.md * updated tools/docker/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue/discussion: #1087 and creates a directory for maintaining dockerfiles.
The directory currently consists of:
The base README.md has also been updated to use the updated path for building devel docker image.
NOTE: I am using pip for installing the tf and tfio packages in
cpu.Dockerfileand not building tfio from scratch to keep the process minimal. (following the same approach as https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/dockerfiles/dockerfiles/cpu.Dockerfile )