added 'import' tests and github actions for docker images #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvignesh1420
changed the title
kvignesh1420
changed the title
|
With the windows setup, was facing the following issue:
A StackOverflow thread suggested setting the docker experimental feature to true/ switch to linux containers (which needs a GUI), but not sure if it is possible in GitHub actions. Additional Reference: actions/runner-images#1143 |
|
cc: @yongtang for review |
|
@kvignesh1420 The PR looks good! I think we might just simply remove the macOS build for docker, as macOS on GitHub Actions has not been super stable? We only need to validate that docker container works (user will most likely use it on Linux). So removing macOS docker build on GitHub Actions should be fine. |
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
…#1090) * added basic tests and github actions * removed -i option from docker run during tests * updated docker test setup for mac and win * removed win docker test * modified docker tests on mac * removed docker tests on macos * added docker tests on macOS * removed docker devel test in macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue: #1087 and is a follow up of PR: #1089
Github actions have been added to test the docker build and package import functionality on the Linux and MacOS platforms.
The tests include the following:
tfio-cpuimage usingcpu.Dockerfileand validate the tfio import in python.tfio-devimage usingdevel.Dockerfile, build tfio from source using bazel and validate it's import in python.