Find replacements for rust-specific CI actions #6155
Comments
|
https://github.com/dtolnay/rust-toolchain is referenced in the mentioned issues above as an alternative to |
This was referenced Jan 19, 2023
groszewn
added a commit
that referenced
this issue
Jan 19, 2023
…y Node.js 16 (#6153) Updates to use the latest (3.6.0) release of [setup-node](https://github.com/actions/setup-node) and bumps the Node.js version to 16. This should get rid of some deprecation warnings we're seeing in our workflow actions (for example, https://github.com/tensorflow/tensorboard/actions/runs/3388287772). However, some other actions still need releases to finish cleaning up these warnings (see #6155). Contributes to #6123.
groszewn
added a commit
that referenced
this issue
Jan 19, 2023
[actions-rs/toolchain](https://github.com/actions-rs/toolchain) and [actions-rs/clippy-check](https://github.com/actions-rs/clippy-check) have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version, `save-state`, `set-output`), so we need to replace these. [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself). `clippy-check` seems to have been generally broken for us, since it [can't post lints as annotations back to the PR if it comes from a fork](actions-rs/clippy-check#2) (which most of our PRs do). Instead, we can simply define the `cargo clippy` command directly in our action and make sure we fail on any raised warnings. This resolves #6155.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this issue
Mar 27, 2023
…y Node.js 16 (tensorflow#6153) Updates to use the latest (3.6.0) release of [setup-node](https://github.com/actions/setup-node) and bumps the Node.js version to 16. This should get rid of some deprecation warnings we're seeing in our workflow actions (for example, https://github.com/tensorflow/tensorboard/actions/runs/3388287772). However, some other actions still need releases to finish cleaning up these warnings (see tensorflow#6155). Contributes to tensorflow#6123.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this issue
Mar 27, 2023
[actions-rs/toolchain](https://github.com/actions-rs/toolchain) and [actions-rs/clippy-check](https://github.com/actions-rs/clippy-check) have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version, `save-state`, `set-output`), so we need to replace these. [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself). `clippy-check` seems to have been generally broken for us, since it [can't post lints as annotations back to the PR if it comes from a fork](actions-rs/clippy-check#2) (which most of our PRs do). Instead, we can simply define the `cargo clippy` command directly in our action and make sure we fail on any raised warnings. This resolves tensorflow#6155.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this issue
May 1, 2023
…y Node.js 16 (tensorflow#6153) Updates to use the latest (3.6.0) release of [setup-node](https://github.com/actions/setup-node) and bumps the Node.js version to 16. This should get rid of some deprecation warnings we're seeing in our workflow actions (for example, https://github.com/tensorflow/tensorboard/actions/runs/3388287772). However, some other actions still need releases to finish cleaning up these warnings (see tensorflow#6155). Contributes to tensorflow#6123.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this issue
May 1, 2023
[actions-rs/toolchain](https://github.com/actions-rs/toolchain) and [actions-rs/clippy-check](https://github.com/actions-rs/clippy-check) have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version, `save-state`, `set-output`), so we need to replace these. [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself). `clippy-check` seems to have been generally broken for us, since it [can't post lints as annotations back to the PR if it comes from a fork](actions-rs/clippy-check#2) (which most of our PRs do). Instead, we can simply define the `cargo clippy` command directly in our action and make sure we fail on any raised warnings. This resolves tensorflow#6155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The rust-specific GH actions (i.e. actions-rs/clippy-check and actions-rs/toolchain) both use Node.js 12 and have been largely untouched since 2020. Deprecation of workflows using Node.js 12 is well underway (https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/) and there's been no movement on the two actions to upgrade (clippy check tracking issue, toolchain tracking issue).
We'll want to find alternatives to ensure CI continues to run in the case that new versions aren't released.
The text was updated successfully, but these errors were encountered: