ci: Replace unmaintained actions-rs GH actions #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groszewn
force-pushed
the
rust_ci_updates
branch
4 times, most recently
from
c62e087
to
5b30b01
Compare
[actions-rs/toolchain](https://github.com/actions-rs/toolchain) and [actions-rs/clippy-check](https://github.com/actions-rs/clippy-check) have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version, `save-state`, `set-output`), so we need to replace these. [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself). `clippy-check` seems to have been generally broken for us, since it [can't post lints as annotations back to the PR if it comes from a fork](actions-rs/clippy-check#2) (which most of our PRs do). Instead, we can simply define the `cargo clippy` command directly in our action and make sure we fail on any raised warnings.
…new to avoid deprecation warnings
groszewn
force-pushed
the
rust_ci_updates
branch
from
5b30b01
to
d6846d6
Compare
nfelt
approved these changes
Jan 19, 2023
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
[actions-rs/toolchain](https://github.com/actions-rs/toolchain) and [actions-rs/clippy-check](https://github.com/actions-rs/clippy-check) have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version, `save-state`, `set-output`), so we need to replace these. [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself). `clippy-check` seems to have been generally broken for us, since it [can't post lints as annotations back to the PR if it comes from a fork](actions-rs/clippy-check#2) (which most of our PRs do). Instead, we can simply define the `cargo clippy` command directly in our action and make sure we fail on any raised warnings. This resolves tensorflow#6155.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
[actions-rs/toolchain](https://github.com/actions-rs/toolchain) and [actions-rs/clippy-check](https://github.com/actions-rs/clippy-check) have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version, `save-state`, `set-output`), so we need to replace these. [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself). `clippy-check` seems to have been generally broken for us, since it [can't post lints as annotations back to the PR if it comes from a fork](actions-rs/clippy-check#2) (which most of our PRs do). Instead, we can simply define the `cargo clippy` command directly in our action and make sure we fail on any raised warnings. This resolves tensorflow#6155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actions-rs/toolchain and actions-rs/clippy-check have not been updated in the last two years. There are multiple GH action warnings coming from our usage of these actions (Node.js version,
save-state,set-output), so we need to replace these.dtolnay/rust-toolchain is maintained and is roughly a drop-in replacement (modulo one of two arguments to the action itself).
clippy-checkseems to have been generally broken for us, since it can't post lints as annotations back to the PR if it comes from a fork (which most of our PRs do). Instead, we can simply define thecargo clippycommand directly in our action and make sure we fail on any raised warnings.This resolves #6155.