Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xtensa workflow does not appear to be catching errors from the PR #182

Closed
advaitjain opened this issue Jun 16, 2021 · 1 comment · Fixed by #184
Closed

Xtensa workflow does not appear to be catching errors from the PR #182

advaitjain opened this issue Jun 16, 2021 · 1 comment · Fixed by #184

Comments

@advaitjain
Copy link
Member

Here is a PR that resulted in the Xtensa build being broken:
#169

While the checks from that PR all passed, we can run the Xtensa workflow on main and see that it is failing:
https://github.com/tensorflow/tflite-micro/actions/runs/943815585

We are using the pull_request_target trigger:

tflite-micro/.github/workflows/xtensa.yml

Lines 10 to 14 in 36c507e

on:
pull_request_target:
types: [labeled]
branches:
- main

And using the checkout action with the default ref param:

tflite-micro/.github/workflows/xtensa.yml

Line 34 in 36c507e

- uses: actions/checkout@v2

@advaitjain advaitjain mentioned this issue Jun 16, 2021
Merged
advaitjain added a commit that referenced this issue Jun 16, 2021
@advaitjain
Explicitly use python3 from the Makefile. (#178)
57c2576 
For the Xtensa docker container, we were getting an error message along the lines of python not found. And the result was that the specialization was happening incorrectly (i.e. the specialization for the kernels was failing since it relies on python since #160).

#182 is likely the reason why this error passed the CI for #160 but started failing after.
advaitjain added a commit to advaitjain/tflite-micro that referenced this issue Jun 16, 2021
@advaitjain
Fix tensorflow#182 by explicitly checking out pull_request.head.sha
2515bf6 
Similar to actions/checkout#518
@advaitjain advaitjain mentioned this issue Jun 16, 2021
Merged
@advaitjain
Copy link
Member Author

Verified with #185 that errors in the PR will be caught by the Xtensa check.

@advaitjain advaitjain linked a pull request Jun 16, 2021 that will close this issue
Fix #182 by explicitly checking out pull_request.head.sha #184
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #182 by explicitly checking out pull_request.head.sha advaitjain/tflite-micro
1 participant
@advaitjain