Explicitly use python3 from the Makefile. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Xtensa docker container, we were getting an error message along the lines of `python not found`. And the result was that the specialization was happening incorrectly (i.e. the specialization for the kernels was failing since it relies on python since tensorflow#160). Exactly why this error passed the CI for tensorflow#160 but started failing after is not entrely clear but is something that we are not going to investigate.
|
I have instead updated the Xtensa docker image to install python. |
rockyrhodes
approved these changes
Jun 16, 2021
|
@rockyrhodes was also seeing this issue and its likely best to explicitly use python3 even though the Xtensa docker image now has python. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Xtensa docker container, we were getting an error message along the lines of
python not found. And the result was that the specialization was happening incorrectly (i.e. the specialization for the kernels was failing since it relies on python since #160).#182 is likely the reason why this error passed the CI for #160 but started failing after.