Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the Docker Run Action and usage #12775

Closed
dimitri-tenstorrent opened this issue Sep 17, 2024 · 0 comments
Closed

Clean up the Docker Run Action and usage #12775

dimitri-tenstorrent opened this issue Sep 17, 2024 · 0 comments
Assignees
@dimitri-tenstorrent
Milestone
Ubuntu 22.04/24.0...

Comments

@dimitri-tenstorrent
Copy link
Contributor

  • Pass an argument to install the wheel
  • Remove username and password and just get that information inside of the wheel
  • Do not set the environment variables that are not necessary for wheel environmnet like /lib/build
  • Do not pass Arch into the docker run action as it is not necessary
@dimitri-tenstorrent dimitri-tenstorrent self-assigned this Sep 17, 2024
dimitri-tenstorrent added a commit that referenced this issue Sep 17, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
d796e68 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
@dimitri-tenstorrent dimitri-tenstorrent mentioned this issue Sep 17, 2024
Merged
7 tasks
dimitri-tenstorrent added a commit that referenced this issue Sep 17, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
5a0ad02 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
dimitri-tenstorrent added a commit that referenced this issue Sep 19, 2024
@dimitri-tenstorrent
#12775: Do not mount the folder in a readonly fashion; allow the fil…
434e7b2 
…es to be written back to the filesystem
dimitri-tenstorrent added a commit that referenced this issue Sep 19, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
2a2580f 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
dimitri-tenstorrent added a commit that referenced this issue Sep 19, 2024
@dimitri-tenstorrent
#12775: Do not mount the folder in a readonly fashion; allow the fil…
ccbcf98 
…es to be written back to the filesystem
dimitri-tenstorrent added a commit that referenced this issue Sep 20, 2024
@dimitri-tenstorrent
#12775: Add the required shell attribute
c8a5c1e
dimitri-tenstorrent added a commit that referenced this issue Sep 20, 2024
@dimitri-tenstorrent
#12775: Need to cd into another folder
4c919a9
dimitri-tenstorrent added a commit that referenced this issue Sep 20, 2024
@dimitri-tenstorrent
#12775: Use virtual env to run commands
d655c58
dimitri-tenstorrent added a commit that referenced this issue Sep 20, 2024
@dimitri-tenstorrent
#12775: Use a folder not right under root
57dbbac
dimitri-tenstorrent added a commit that referenced this issue Sep 20, 2024
@dimitri-tenstorrent
#12775: The wheel path has to delete tt_metal and tt_eager and needs…
23a1cd7 
… a separate path
dimitri-tenstorrent added a commit that referenced this issue Sep 22, 2024
@dimitri-tenstorrent
#12775: Incorproate not needing to delete the folders and also mount…
ef67e26 
… the required files for permissions
dimitri-tenstorrent added a commit that referenced this issue Sep 22, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
dfee0e1 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
   - Incorproate the new learning of not needing to delete the folders and also mount the required files for permissions
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Try the run only on selected machines
ef0937c
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Output IDs to help with the debugging of the error
cbd1e2c
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Also add the runner's ids
dcff71b
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Install new packages in the environment as the UID GID were …
fa2eacc 
…causing issues
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Install into the environment and not the user's site packages
e1ec6e8
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Set HOME variable so that the packagaes would be installed i…
ded4d33 
…n the .local folder
dimitri-tenstorrent added a commit that referenced this issue Sep 23, 2024
@dimitri-tenstorrent
#12775: Remove the usage of echo UID and GID
d02f128
dimitri-tenstorrent added a commit that referenced this issue Sep 24, 2024
@dimitri-tenstorrent
#12775: Revert labels
32d9616
dimitri-tenstorrent added a commit that referenced this issue Sep 24, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
7c2757d 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
   - Incorproate the new learning of not needing to delete the folders and also mount the required files for permissions
   - Set HOME variable so that the packagaes would not be installed in the /home/ubuntu/.local folder
dimitri-tenstorrent added a commit that referenced this issue Sep 24, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
82876fe 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
   - Incorproate the new learning of not needing to delete the folders and also mount the required files for permissions
   - Set HOME variable so that the packagaes would not be installed in the /home/ubuntu/.local folder
dimitri-tenstorrent added a commit that referenced this issue Sep 24, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
3b80666 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
   - Incorproate the new learning of not needing to delete the folders and also mount the required files for permissions
   - Set HOME variable so that the packagaes would not be installed in the /home/ubuntu/.local folder
dimitri-tenstorrent added a commit that referenced this issue Sep 24, 2024
@dimitri-tenstorrent
#12775: Cleanup docker run action
cef5730 
   - Remove unnecessary arch parameter of the docker run action
   - Add a parameter to installing the wheel
   - Remove LD_LIBRARY env variable since it is not used in the wheel environments
   - Remove Github username since it is accessible inside of the custom Action
   - Incorproate the new learning of not needing to delete the folders and also mount the required files for permissions
   - Set HOME variable so that the packagaes would not be installed in the /home/ubuntu/.local folder
@tenstorrent tenstorrent deleted a comment from Dimitri-Gnidash Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitri-tenstorrent dimitri-tenstorrent

Labels
None yet
Projects
None yet
Milestone
Ubuntu 22.04/24.04 support
Development

No branches or pull requests
1 participant
@dimitri-tenstorrent