-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12775: Cleanup docker run action #12777
#12775: Cleanup docker run action #12777
Conversation
@@ -64,12 +62,9 @@ jobs: | |||
timeout-minutes: ${{ inputs.timeout }} | |||
uses: ./.github/actions/docker-run | |||
with: | |||
docker_username: ${{ github.actor }} | |||
install_wheel: true | |||
docker_password: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not move the docker_password parameter to be filled by default since secrets
are not available inside of Github custom Actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have we tried using
secrets: inherit?
https://docs.github.com/en/actions/sharing-automations/reusing-workflows#using-inputs-and-secrets-in-a-reusable-workflow
Seem strange that a github action can't get access to custom GH actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I have tried and the secrets are inaccessible in the Github actions - see here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is true - the secrets
context in general is not available in a composite action. You explictly must pass it
@@ -65,4 +68,8 @@ runs: | |||
cp -r /github_workspace/* /usr/app/ | |||
cd /usr/app/ | |||
rm -rf tt_metal tt_eager | |||
if [ ${{ inputs.install_wheel }} ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we mention in the meeting if we wanted to move the artifact downloading into the docker run action?
I do not know if that makes sense but I also do not like the dependency on the wheel presence that is implicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wheel artifact. This action relies on its presence but there is no explicit dependency defined in the Github Acton jobs.
d796e68
to
5a0ad02
Compare
434e7b2
to
ccbcf98
Compare
- Remove unnecessary arch parameter of the docker run action - Add a parameter to installing the wheel - Remove LD_LIBRARY env variable since it is not used in the wheel environments - Remove Github username since it is accessible inside of the custom Action - Incorproate the new learning of not needing to delete the folders and also mount the required files for permissions - Set HOME variable so that the packagaes would not be installed in the /home/ubuntu/.local folder
82876fe
to
3b80666
Compare
Ticket
#12775
Problem description
During the review several issues were highlighted of how to make the Docker Run Action be a cleaner interface.
What's changed
Additional features we might want in this PR
docker system prune
as the first step for self-healingChecklist