-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new packages: shotcut, mlt and their deps #20353
Conversation
This package will be ready and I will force-push it once #20352 and #20374 are merged. |
Please make sure to add termux_step_pre_configure(){
CXXFLAGS+=' -Wno-c++11-narrowing'
} to make sure the 32 bit builds succeed. |
Thanks and will do when movit is available |
In that case I'm gonna go ahead and merge movit. |
Tested on my aarch64 phone. Import playlist, track editor, preview, some basic filters (rotate, opacity), export work. Ready to be merged. See if you are fine with the way I patch the source code. |
Please change all the .patch files that hardcoded with |
fixed. thanks |
x11-packages/mlt/0001-cmake-mlt-undefined-version.patch and x11-packages/mlt/0002-cmake-mlt++-undefined-version.patch are probably not required. The issue can be fixed with |
Thanks @Biswa96 . You are right and force-pushed. |
Please change TERMUX_PKG_MAINTAINER field |
oh right, fixed. |
Just realized that this PR should be ready but has not yet merged. Any chance merging to provide |
LGTM. fixes #20021 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went in and updated the build scripts.
I had to regenerate mlt/0004-fhs-path.patch
, but that was just some line drift causing the 7.24.0 version of the patch to no longer apply.
Guess that's what I get for only testing against AArch64 locally. ld.lld: error: undefined symbol: Mlt::Producer::set_creation_time(long long)
>>> referenced by mltcontroller.cpp
>>> src/CMakeFiles/shotcut.dir/mltcontroller.cpp.o:(Mlt::Controller::setupNewProducer(Mlt::Producer*) const)
>>> referenced by mltcontroller.cpp
>>> src/CMakeFiles/shotcut.dir/mltcontroller.cpp.o:(Mlt::Controller::lockCreationTime(Mlt::Producer*) const)
>>> referenced by filedatedialog.cpp
>>> src/CMakeFiles/shotcut.dir/dialogs/filedatedialog.cpp.o:(FileDateDialog::accept())
clang++: error: linker command failed with exit code 1 (use -v to see invocation) |
Related to mltframework/shotcut#1580 and mltframework/mlt#1020.
Honestly, I am not so sure how to make a conditional patch other than writing some sed shell script. Help is appreciated. Thanks. |
Should be easy enough. |
termux-packages/packages/util-linux/build.sh Lines 61 to 63 in 31e2ed4
We can use the same approach and just apply a |
e404c1d
to
d409b20
Compare
EDITED: Can't build even reverting to your version. Clueless and shouldn't relates to libicu cuz there was no update. Previous incorrect comments.
|
The cross tools need to be rebuilt after the Ubuntu base image upgraded to 24.04. |
d409b20
to
7a019bb
Compare
Thanks a lot! Ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks a lot for your contribution and working with us on it.
Draft PR. currently the app mostly works
well but cannot output video results, perhaps there are problems with QProcess, see #20354 .[fixed]Other things to note:
32-bit arch does not build (see error log, related toqint64
type)GPU mode requires PR new package: movit #20352 , related to [Help] Cross compilemovit
(shotcut
&mlt
GPU deps), which can build on-device #20351pipewire
seems not tested and it is not working #20316opencv
cannot be included asmlt
build deps (which is done by Archlinux), prompting some compilation error related toQPrivate
when buildingshotcut