-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new package: movit #20352
new package: movit #20352
Conversation
Interesting, the builds are actually failing differently between x86 and Aarch64. |
Please do keep your commits squashed by the way. See https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits for for info on interactive rebase. |
I rectified the build script following your review. After all, the similarity in x86 and aarch64 build is that they both fail to run I pause here and perhaps wait for someone who knows any around to cross-compile it. And also for fixing the symbol issue for |
Regarding the missing symbols on arm. termux-packages/packages/marisa/build.sh Lines 12 to 20 in 6cac06b
May need to be adjusted slightly, but LDFLAGS+=" $($CC -print-libgcc-file-name)" seems to be the operative part.
|
Thanks a lot! The Still, I highly doubt if this package can be cross-compiled. More work may be needed to look into movit's build script. |
sorry about the delay on the CI runs, I need to approve them manually since this is a first time contribution |
huh just rewrite it in Python, that's of course also an option. |
thanks a lot @licy183 |
I did also test building shortcut with |
Tested with shotcut (settings -> GPU effects (unstable)) on my device (Snapdragon 8 Gen 2) Still, we may add this for mlt framework and shotcut, provided that it is an opt-in feature. |
Following #20351, try to make a PR here to see if Actions of this repo can build
movit
package which is supposed to require on device build.