Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new package: movit #20352

Merged
merged 1 commit into from
May 31, 2024
Merged

new package: movit #20352

merged 1 commit into from
May 31, 2024

Conversation

knyipab
Copy link
Contributor

@knyipab knyipab commented May 29, 2024

Following #20351, try to make a PR here to see if Actions of this repo can build movit package which is supposed to require on device build.

packages/movit/build.sh Outdated Show resolved Hide resolved
packages/movit/build.sh Outdated Show resolved Hide resolved
@TomJo2000
Copy link
Member

Interesting, the builds are actually failing differently between x86 and Aarch64.

@TomJo2000
Copy link
Member

Please do keep your commits squashed by the way.
You can use git rebase -i HEAD~2 to do so.
And you will probably want to commit subsequent revisions with git commit --amend to amend the HEAD commit.

See https://www.baeldung.com/ops/git-squash-commits#1-squash-the-last-x-commits for for info on interactive rebase.

@knyipab
Copy link
Contributor Author

knyipab commented May 29, 2024

I rectified the build script following your review.

After all, the similarity in x86 and aarch64 build is that they both fail to run ./make_bundled_shaders to generate cpp file, error prompt is a bit different cuz x86 host tries to runs aarch64 binary.

I pause here and perhaps wait for someone who knows any around to cross-compile it. And also for fixing the symbol issue for arm if that's do-able.

@TomJo2000
Copy link
Member

Regarding the missing symbols on arm.
Code search actually dug up an existing solution.

termux_step_pre_configure() {
# fix arm build and potentially other archs hidden bugs
# ERROR: lib/libmarisa.so contains undefined symbols:
# 39: 00000000 0 NOTYPE GLOBAL DEFAULT UND __aeabi_uidiv
# 40: 00000000 0 NOTYPE GLOBAL DEFAULT UND __aeabi_idiv
# 49: 00000000 0 NOTYPE GLOBAL DEFAULT UND __aeabi_idivmod
LDFLAGS+=" $($CC -print-libgcc-file-name)"
autoreconf -fi
}

May need to be adjusted slightly, but LDFLAGS+=" $($CC -print-libgcc-file-name)" seems to be the operative part.

@knyipab
Copy link
Contributor Author

knyipab commented May 29, 2024

Thanks a lot! The arm fix works as I updated in the TUR PR.

Still, I highly doubt if this package can be cross-compiled. More work may be needed to look into movit's build script.

@TomJo2000
Copy link
Member

sorry about the delay on the CI runs, I need to approve them manually since this is a first time contribution

@TomJo2000
Copy link
Member

huh just rewrite it in Python, that's of course also an option.
Nice thinking @licy183.

@knyipab
Copy link
Contributor Author

knyipab commented May 30, 2024

thanks a lot @licy183

@TomJo2000 TomJo2000 marked this pull request as ready for review May 30, 2024 11:22
@TomJo2000
Copy link
Member

I did also test building shortcut with movit from this PR and it built fine.

@knyipab
Copy link
Contributor Author

knyipab commented May 31, 2024

Tested with shotcut (settings -> GPU effects (unstable)) on my device (Snapdragon 8 Gen 2)
The movit track editor is signjficantly slower than cpu mode except for zink in dri3 + generic vulkan loader.
The export outputting a overlay video does not work well (only the top video rendered).
I tried a number of GPU acceleration setups but don't find any useful.

Still, we may add this for mlt framework and shotcut, provided that it is an opt-in feature.

@TomJo2000 TomJo2000 merged commit 4d65d51 into termux:master May 31, 2024
Freed-Wu pushed a commit to Freed-Wu/termux-packages that referenced this pull request Jun 6, 2024
bigbio2002 pushed a commit to bigbio2002/termux-packages that referenced this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants