Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out deprecated app_engine arg into its own resource/module (v2.0) #134

Closed

Conversation

nstogner
Copy link

The app_engine field in the google_project resource is deprecated.

Options:

  1. Remove app engine functionality from project factory
  2. Integrate the app engine resource into project factory

This PR is for option 2.

Option 2 requires removing the app_engine arg and replacing with more granular args. This is needed b/c of terraform's limitation in accessing nested map fields (app_engine["feature_settings"]). Note: Option 2 also requires the user to terraform import the new resource as a part of the upgrade path, ex:

terraform import module.project-factory.module.project-factory.module.app-engine.google_app_engine_application.app pf-ci-test-full-y2d5b2ae-0d6c

@nstogner nstogner changed the title Break out deprecated app_engine arg into its own resource/module [WIP] Break out deprecated app_engine arg into its own resource/module Jan 24, 2019
@adrienthebo
Copy link
Contributor

Noting for posterity that this is a backwards incompatible change since it changes the Project Factory interface.

@nstogner nstogner changed the title [WIP] Break out deprecated app_engine arg into its own resource/module Break out deprecated app_engine arg into its own resource/module Jan 25, 2019
@nstogner nstogner changed the title Break out deprecated app_engine arg into its own resource/module Break out deprecated app_engine arg into its own resource/module (v2.0) Jan 25, 2019
@morgante
Copy link
Contributor

Looks like this is causing tests to fail. Please investigate.

@Zest-nikunj
Copy link

@nstogner Whenever I try to run a terraform plan with the module, I get an error:
project-factory.google_project.main: "app_engine": this field cannot be set
Any suggestions?

@mikeraimondi
Copy link

I am also getting the error "project-factory.google_project.main: "app_engine": this field cannot be set" with v2.0.0 of the Google provider.

@morgante
Copy link
Contributor

Replaced with #144.

@morgante morgante closed this Feb 22, 2019
@Zest-nikunj
Copy link

Zest-nikunj commented Feb 24, 2019

I am also getting the error "project-factory.google_project.main: "app_engine": this field cannot be set" with v2.0.0 of the Google provider.

I had to comment the app_engine variable, https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/modules/core_project_factory/main.tf#L93
to make it work. @mikeraimondi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants