-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out deprecated app_engine arg into its own resource/module (v2.0) #134
Break out deprecated app_engine arg into its own resource/module (v2.0) #134
Conversation
Noting for posterity that this is a backwards incompatible change since it changes the Project Factory interface. |
Looks like this is causing tests to fail. Please investigate. |
@nstogner Whenever I try to run a terraform plan with the module, I get an error: |
I am also getting the error "project-factory.google_project.main: "app_engine": this field cannot be set" with v2.0.0 of the Google provider. |
Replaced with #144. |
I had to comment the app_engine variable, https://github.com/terraform-google-modules/terraform-google-project-factory/blob/master/modules/core_project_factory/main.tf#L93 |
The
app_engine
field in thegoogle_project
resource is deprecated.Options:
This PR is for option 2.
Option 2 requires removing the
app_engine
arg and replacing with more granular args. This is needed b/c of terraform's limitation in accessing nested map fields (app_engine["feature_settings"]
). Note: Option 2 also requires the user toterraform import
the new resource as a part of the upgrade path, ex: