Breakout app engine #144
Merged
Breakout app engine #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
7fa0199
to
584beb1
Compare
morgante
previously approved these changes
Feb 22, 2019
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
5656887
to
fa902ee
Compare
aaron-lane
suggested changes
Feb 22, 2019
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
4 times, most recently
from
7ccc0b1
to
145e66b
Compare
aaron-lane
suggested changes
Feb 22, 2019
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
448b916
to
5217b36
Compare
aaron-lane
previously approved these changes
Feb 22, 2019
|
This looks good, but let's hold off from merging until the regression in 1.1.0 is fixed. |
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
3 times, most recently
from
f37ea3c
to
d92e749
Compare
aaron-lane
suggested changes
Feb 25, 2019
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
805a379
to
c0ee5c5
Compare
aaron-lane
previously approved these changes
Feb 27, 2019
|
Test of migration guide logic: https://gist.github.com/thefirstofthe300/ed385de387659ba6efacb984fcedb442 |
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
3 times, most recently
from
75226ec
to
c6ca872
Compare
aaron-lane
suggested changes
Mar 5, 2019
There was a problem hiding this comment.
The feature_settings variable needs some attention as described below.
Can you regenerate the documentation using the latest version of terraform-docs to ensure that the escaping isn't removed.
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
c6ca872
to
38c8a9b
Compare
aaron-lane
previously approved these changes
Mar 5, 2019
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
38c8a9b
to
df7a26c
Compare
…g module interfaces
thefirstofthe300
force-pushed
the
breakout-app-engine
branch
from
df7a26c
to
479b9bd
Compare
aaron-lane
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of the commits made by Nick Stogner in #134.
Refactors project factory's App Engine configuration to no longer use the deprecated and now removed
app_engine_configblock from thegoogle_projectresource.