r/role_definition: fixing a crash when permissions is nil & making permissions optional
#9850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
force-pushed
the
b/role-definition-crash-9815
branch
from
9600098
to
cd3b299
Compare
tombuildsstuff
force-pushed
the
b/role-definition-crash-9815
branch
from
cd3b299
to
42d8101
Compare
This was referenced Jan 29, 2021
jackofallops
force-pushed
the
b/role-definition-crash-9815
branch
from
42d8101
to
54bb177
Compare
The API returns an empty list if an empty permissions block is sent but also allows sending an empty list - so it appears that this isn't required.
…ttled down Turns out the Update call is eventually consistent - where a new Role Definition gets created and then reconciled on the backend. This new Role Definition has a new CreatedOn and UpdatedOn, so it's possible to determine when this has been updated - however in testing it can take ~5m for this to settle down. Whilst it's unfortunate this takes a little longer to settle down, this should improve the reliability of resources which depend on this. Unfortunately the Azure SDK doesn't expose these fields in the response, so for now we're using a wrapped to access them and confirm this has been updated.
jackofallops
force-pushed
the
b/role-definition-crash-9815
branch
from
e2d5f1f
to
591026b
Compare
|
Tests look good:
|
jackofallops
added a commit
that referenced
this pull request
Mar 25, 2021
|
This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.53.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing it appears this block can be left empty (e.g.
[]) - since the API will transform an empty permissions block into[]Fixes #9815
Fixes #440
Fixes #3732