-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/role_definition: fixing a crash when permissions
is nil & making permissions optional
#9850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
9600098
to
cd3b299
Compare
cd3b299
to
42d8101
Compare
42d8101
to
54bb177
Compare
The API returns an empty list if an empty permissions block is sent but also allows sending an empty list - so it appears that this isn't required.
…ttled down Turns out the Update call is eventually consistent - where a new Role Definition gets created and then reconciled on the backend. This new Role Definition has a new CreatedOn and UpdatedOn, so it's possible to determine when this has been updated - however in testing it can take ~5m for this to settle down. Whilst it's unfortunate this takes a little longer to settle down, this should improve the reliability of resources which depend on this. Unfortunately the Azure SDK doesn't expose these fields in the response, so for now we're using a wrapped to access them and confirm this has been updated.
e2d5f1f
to
591026b
Compare
This has been released in version 2.53.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.53.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
In testing it appears this block can be left empty (e.g.
[]
) - since the API will transform an empty permissions block into[]
Fixes #9815
Fixes #440
Fixes #3732