Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error if boot disk specified on non-first disk in instance template #5491

Conversation

modular-magician
Copy link
Collaborator

Fixes: #5428

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_instance_template` add plan time check for any disks marked `boot` outside of the first disk

Derived from GoogleCloudPlatform/magic-modules#2996

…te (hashicorp#2996)

* Add error if boot disk specified on non-first disk in instance template

* Move error to plan time rather than apply time

Signed-off-by: Modular Magician <[email protected]>
@ghost ghost added the size/xs label Jan 24, 2020
@modular-magician modular-magician merged commit 87ffb97 into hashicorp:master Jan 24, 2020
@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boot to set true for non-boot disks
1 participant