Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing jetbrain annotations #3100

Closed

Conversation

artjomka
Copy link
Contributor

Issue #3057
Additionally clean up @Nullable annotation, maybe that was overkill and need to think of some kind of replacement for that if needed

artjom.kalita and others added 30 commits January 31, 2020 10:42
…tcontainers#2271)

* Bump junit-jupiter-api from 5.5.2 to 5.6.0 in /modules/junit-jupiter

Bumps [junit-jupiter-api](https://github.com/junit-team/junit5) from 5.5.2 to 5.6.0.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.5.2...r5.6.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Match engine and API versions to fix compile error

Co-authored-by: Richard North <[email protected]>
…tcontainers#2287)

* Add small delay in while loop to avoid spamming logs (ResourceReaper)

* Add small delay in while loop to avoid spamming logs (ResourceReaper) - Replaced Thread.sleep with RateLimiter
Co-authored-by: Richard North <[email protected]>
Co-authored-by: Sergei Egorov <[email protected]>
* Add Presto container

* Add incubating note to module docs

Co-authored-by: Richard North <[email protected]>
…ers#2344)

Bumps tomcat-jdbc from 9.0.30 to 9.0.31.

Signed-off-by: dependabot-preview[bot] <[email protected]>
…iners#2343)

Bumps tomcat-jdbc from 9.0.30 to 9.0.31.

Signed-off-by: dependabot-preview[bot] <[email protected]>
dependabot-preview bot and others added 22 commits February 28, 2020 16:37
Bumps commons-compress from 1.19 to 1.20.

Signed-off-by: dependabot-preview[bot] <[email protected]>
Fixes issue testcontainers#2280
By default, sourceJar.from = allJava (see gradle/publishing.gradle)
But Spock module is in Groovy
  => sourceJar.from should be allGroovy/allSource

Co-authored-by: Richard North <[email protected]>
…tcontainers#2282)

Co-authored-by: Luis Miguel Mejía Suárez <[email protected]>
Co-authored-by: Richard North <[email protected]>

Co-authored-by: Luis Miguel Mejía Suárez <[email protected]>
Co-authored-by: Kevin Wittek <[email protected]>
@bsideup
Copy link
Member

bsideup commented Aug 14, 2020

@artjomka IIRC the idea in #3057 was to make the dependency compileOnly while keeping the annotations (e.g. for Kotlin folks)

I will have another look after you rebase your PR (there is a bunch of unrelated commits), but I guess we don't need to remove the annotations themselves.

@artjomka artjomka closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants