-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: create new jobs for React next #728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 100 100
Branches 16 16
=========================================
Hits 100 100 Continue to review full report at Codecov.
|
https://travis-ci.org/github/testing-library/react-testing-library/builds/704028047 Seems to be working, do we want to merge this and wait for the next cron build on master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really fix #726. The build still fails for react@next
. We're just ignoring it because it's not as sever if it fails for experimental builds. We should still investigate if the issue is on our side or React's.
I see what you mean. This technically does fix the overall build though, which is what the issue was originally for. Do you want to rename it or open another issue for the timing of React next? |
As far as I can tell the test is still failing. |
This comment has been minimized.
This comment has been minimized.
We merged this and kept #726 open to track the specific bug with React next. |
🎉 This PR is included in version 10.4.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Why: #726 and greater visibility of what's failing in React next (before a cron build is started on schedule)
How: Split React next into a new section of the build matrix rather than just using it in cron builds
Checklist:
docs site N/A