Skip to content

Commit

Permalink
bucket: inspect help message (#1235)
Browse files Browse the repository at this point in the history
* cmd/bucket inspect: display backslash in selector help message

* docs/compnents/bucket inspect: display backslash in selector help message
  • Loading branch information
rvalkenaers authored and bwplotka committed Jun 10, 2019
1 parent 7b72b18 commit f2356eb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cmd/thanos/bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ func registerBucketLs(m map[string]setupFunc, root *kingpin.CmdClause, name stri

func registerBucketInspect(m map[string]setupFunc, root *kingpin.CmdClause, name string, objStoreConfig *pathOrContent) {
cmd := root.Command("inspect", "Inspect all blocks in the bucket in detailed, table-like way")
selector := cmd.Flag("selector", "Selects blocks based on label, e.g. '-l key1=\"value1\" -l key2=\"value2\"'. All key value pairs must match.").Short('l').
PlaceHolder("<name>=\"<value>\"").Strings()
selector := cmd.Flag("selector", "Selects blocks based on label, e.g. '-l key1=\\\"value1\\\" -l key2=\\\"value2\\\"'. All key value pairs must match.").Short('l').
PlaceHolder("<name>=\\\"<value>\\\"").Strings()
sortBy := cmd.Flag("sort-by", "Sort by columns. It's also possible to sort by multiple columns, e.g. '--sort-by FROM --sort-by UNTIL'. I.e., if the 'FROM' value is equal the rows are then further sorted by the 'UNTIL' value.").
Default("FROM", "UNTIL").Enums(inspectColumns...)

Expand Down
4 changes: 2 additions & 2 deletions docs/components/bucket.md
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,9 @@ Flags:
--objstore.config=<bucket.config-yaml>
Alternative to 'objstore.config-file' flag. Object
store configuration in YAML.
-l, --selector=<name>="<value>" ...
-l, --selector=<name>=\"<value>\" ...
Selects blocks based on label, e.g. '-l
key1="value1" -l key2="value2"'. All key value
key1=\"value1\" -l key2=\"value2\"'. All key value
pairs must match.
--sort-by=FROM... ... Sort by columns. It's also possible to sort by
multiple columns, e.g. '--sort-by FROM --sort-by
Expand Down

0 comments on commit f2356eb

Please sign in to comment.