Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket: inspect help message #1235

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

rvalkenaers
Copy link
Contributor

thanos bucket inspect --help

  -l, --selector=<name>="<value>" ...
                             Selects blocks based on label, e.g. '-l key1="value1" -l key2="value2"'. All key value pairs must match.

must be:

  -l, --selector=<name>=\"<value>\" ...
                             Selects blocks based on label, e.g. '-l key1=\"value1\" -l key2=\"value2\"'. All key value pairs must match.

I also updated the docs.

Changes

  • add backslashes to bucket inspect help message
  • add backslashes to bucket inspect docs

Verification

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@bwplotka bwplotka merged commit f2356eb into thanos-io:master Jun 10, 2019
@rvalkenaers rvalkenaers deleted the bucket-selector-help branch June 11, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants